feat: Add placeholder spanner methods for new tables #1705
+327
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds placeholder methods for the spanner layer.
There are two sync methods. These will be used during the ingestion of the web features data.
Then there are two `Get` methods which will be used during `/v1/features/{featureid}` in the event the feature key does not exist in the existing Web Features Table.
jrobbins
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds placeholder methods for the spanner layer. With those methods, the adapter/glue layer has been changed to use the sync methods for the web features consumer job.
There are two sync methods. These will be used during the ingestion of the web features data. Then there are two
Getmethods which will be used during/v1/features/{featureid}in the event the feature key does not exist in the existing Web Features Table.