typo needed to compare to 'undefined' not undefined #547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
there's a typo in your comments. It happens to be a highly ranking page on google and i copy pasted the incorrect code only to find out it had a typo |
praveeno
suggested changes
Nov 26, 2017
| @@ -4,7 +4,7 @@ | |||
| function greetES5(message, to) { | |||
| // Test parameter values in the function body, specifying a default | |||
| to = to || 'DOM'; | |||
| // OR if (typeof to === undefined) { to = 'DOM'; } | |||
| // OR if (typeof to === 'undefined') { to = 'DOM'; } | |||
There was a problem hiding this comment.
i think undefined is right, because comment says, if to is undefined then to = 'DOM'. means if to is falsy value undefined then assign 'dom' into to.
beaufortfrancois
force-pushed
the
gh-pages
branch
7 times, most recently
from
c198a70 to
03c4155
Compare
beaufortfrancois
force-pushed
the
gh-pages
branch
5 times, most recently
from
1de1b35 to
c4f3954
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.