Sanitise environment variables used in RegExps #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
reviewed
May 7, 2020
Collaborator
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
thanks very much, nice catch @Alhadis! 👍
Co-authored-by: Patrick Hulce <[email protected]>
patrickhulce
approved these changes
May 7, 2020
Collaborator
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
LGTM, thanks @Alhadis! 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PATHandCHROME_PATHvariables are currently being used verbatim for constructing a regular expression:chrome-launcher/src/chrome-finder.ts
Lines 52 to 53 in 9aa64d6
This can lead to confusing behaviour if a user's path contains RegExp metacharacters such as
$or^. Worse still, it leaves room for a malicious actor to inject an expression guaranteed to send the process into performance hell:I also replaced stuff like
`${process.env.PATH}`with simplyprocess.env.PATH, because the former syntax will stringify an undefined value as"undefined", which probably isn't what you want (or expect).