scalajs-dom 2.0.0 support #174
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- I had to hardcode to hardcode to Scala 2.13, should this work with older versions? - hardcoded specific versions of `binding` and `bindable`, not sure if this is desired. - moved to using `import org.scalajs.dom._` instead of the deprecated `import org.scalajs.dom.raw._` tests are green
- add missing element attributes
|
Don't hard code Scala version |
Migrate from Travis CI to Github Actions
|
Removed hard-coded Scala versions |
|
Don't hard code any dependency versions |
Add VS Code settings
Attribute factories
|
I don't have the permission to merge PRs into GlasslabGames/html.scala, and the one who has the permission is enjoying his holiday. What I can do is to merge your branch from Atry#6 into Atry/html.scala and to publish a new version to Would you mind updating the PR targeting Atry/html.scala instead? |
|
I don't mind! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bindingandbindable, not sure if this is desired.import org.scalajs.dom._instead of the deprecatedimport org.scalajs.dom.raw._tests are green