Fix reusable content cross-space page reference resolution #3321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add parentSpaceContext to GitBookSpaceContext type for tracking parent space information - Update ReusableContent component to include parent space context when rendering content from different spaces - Enhance resolveContentRef to check parent space when page resolution fails in current space - Add comprehensive unit tests for the new parent space fallback functionality This resolves broken links to pages in the parent space of reusable content when used across different sites. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
|
Summary of the deployments: Version 1
Version 2
Test content |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Background
When reusable content contains links to pages in its parent space, these links were broken when the reusable content was used in a different space/site. This happened because the
pagesarray was set to[]for cross-space reusable content to prevent unwanted cross-site linking.Solution
The fix introduces a
parentSpaceContextfield inGitBookSpaceContextthat preserves information about the parent space (where the reusable content originates). When page resolution fails in the current space, the system now checks the parent space and uses the existingresolveContentRefInSpacefunction to generate proper absolute URLs.Changes
parentSpaceContextfieldTest plan
🤖 Generated with Claude Code