Skip to content

(GH-2456) Correctly assert version number for tagged commit #2577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 6, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 77 additions & 0 deletions src/GitVersion.App.Tests/TagCheckoutInBuildAgentTests.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
using System;
using System.Collections.Generic;
using System.Linq;
using System.Threading.Tasks;
using GitTools.Testing;
using GitVersion.BuildAgents;
using GitVersion.Core.Tests.Helpers;
using LibGit2Sharp;
using NUnit.Framework;
using Shouldly;

namespace GitVersion.App.Tests
{
[TestFixture]
public class TagCheckoutInBuildAgentTests
{
[Test]
public async Task VerifyTagCheckoutOnAzurePipelines()
{
var env = new Dictionary<string, string>
{
{ AzurePipelines.EnvironmentVariableName, "true" },
{ "BUILD_SOURCEBRANCH", "refs/tags/0.2.0" },
};

await VerifyTagCheckoutVersionIsCalculatedProperly(env);
}

[Test]
public async Task VerifyTagCheckoutOnGitHubActions()
{
var env = new Dictionary<string, string>
{
{ GitHubActions.EnvironmentVariableName, "true" },
{ "GITHUB_REF", "ref/tags/0.2.0" },
};

await VerifyTagCheckoutVersionIsCalculatedProperly(env);
}

private static async Task VerifyTagCheckoutVersionIsCalculatedProperly(Dictionary<string, string> env)
{
using var fixture = new EmptyRepositoryFixture();
var remoteRepositoryPath = PathHelper.GetTempPath();
RepositoryFixtureBase.Init(remoteRepositoryPath);
using (var remoteRepository = new Repository(remoteRepositoryPath))
{
remoteRepository.Config.Set("user.name", "Test");
remoteRepository.Config.Set("user.email", "[email protected]");
fixture.Repository.Network.Remotes.Add("origin", remoteRepositoryPath);
Console.WriteLine("Created git repository at {0}", remoteRepositoryPath);
remoteRepository.MakeATaggedCommit("0.1.0");
Commands.Checkout(remoteRepository, remoteRepository.CreateBranch("develop"));
remoteRepository.MakeACommit();
Commands.Checkout(remoteRepository, remoteRepository.CreateBranch("release/0.2.0"));
remoteRepository.MakeACommit();
Commands.Checkout(remoteRepository, TestBase.MainBranch);
remoteRepository.MergeNoFF("release/0.2.0", Generate.SignatureNow());
remoteRepository.MakeATaggedCommit("0.2.0");

Commands.Fetch((Repository)fixture.Repository, "origin", new string[0], new FetchOptions(), null);
Commands.Checkout(fixture.Repository, "0.2.0");
}

var programFixture = new ProgramFixture(fixture.RepositoryPath);
programFixture.WithEnv(env.ToArray());

var result = await programFixture.Run();

result.ExitCode.ShouldBe(0);
result.OutputVariables.FullSemVer.ShouldBe("0.2.0");

// Cleanup repository files
DirectoryHelper.DeleteDirectory(remoteRepositoryPath);
}
}
}
12 changes: 10 additions & 2 deletions src/GitVersion.Core/VersionCalculation/NextVersionCalculator.cs
Original file line number Diff line number Diff line change
Expand Up @@ -56,15 +56,23 @@ public SemanticVersion FindVersion()
}

var baseVersion = baseVersionCalculator.GetBaseVersion();
baseVersion.SemanticVersion.BuildMetaData = mainlineVersionCalculator.CreateVersionBuildMetaData(baseVersion.BaseVersionSource);
SemanticVersion semver;
if (context.Configuration.VersioningMode == VersioningMode.Mainline)
{
semver = mainlineVersionCalculator.FindMainlineModeVersion(baseVersion);
}
else
{
semver = PerformIncrement(baseVersion);
semver.BuildMetaData = mainlineVersionCalculator.CreateVersionBuildMetaData(baseVersion.BaseVersionSource);
if (taggedSemanticVersion?.BuildMetaData == null || (taggedSemanticVersion.BuildMetaData.Sha != baseVersion.SemanticVersion.BuildMetaData.Sha))
{
semver = PerformIncrement(baseVersion);
semver.BuildMetaData = mainlineVersionCalculator.CreateVersionBuildMetaData(baseVersion.BaseVersionSource);
}
else
{
semver = baseVersion.SemanticVersion;
}
}

var hasPreReleaseTag = semver.PreReleaseTag.HasTag();
Expand Down