Skip to content

auth: suport ActionCodeSettings.linkDomain #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 19, 2025

Conversation

treitter
Copy link
Contributor

This adds the ActionCodeSettings.linkDomain property to support custom domains in auth (overridding the default PROJECT_ID.firebaseapp.com authentication links).

This PR should fix issue 731.

Supported platforms:

  • android
  • ios
  • js

Unsupported platforms:

  • jvm (seems to be missing some lower-level support or I just missed the jvm dependency though it seems to just use the android one)

I haven't been able to test this since I haven't been able to resolve some issues with mavenLocal. But this is basically a copy-paste-edit of dynamicLinkDomain so it should work with, at most, trivial fixes.

@treitter
Copy link
Contributor Author

I haven't been able to test this since I haven't been able to resolve some issues with mavenLocal. But this is basically a copy-paste-edit of dynamicLinkDomain so it should work with, at most, trivial fixes.

I worked out a solution for my mavenLocal issues and confirmed success accordingly:

  • android: works
  • ios: works
  • js: untested but seems likely to work
  • jvm: unimplemented (not sure the proper way to implement)

Please let me know if there's anything I can do to help get this merged and released.

Thanks again!

@Reedyuk
Copy link
Collaborator

Reedyuk commented Aug 10, 2025

happy for you to rebase yours and i will close mine otherwise:
#741

@treitter treitter force-pushed the issue-731-linkDomain branch from ec73ad5 to cf894a3 Compare August 15, 2025 05:23
@treitter
Copy link
Contributor Author

@Reedyuk I just rebased on master and pushed my branch - anything else you need me to do? Thanks.

@Reedyuk
Copy link
Collaborator

Reedyuk commented Aug 18, 2025

@nbransby are we ok to merge this in after updating the api check?

@Reedyuk
Copy link
Collaborator

Reedyuk commented Aug 18, 2025

@treitter - can you run ./gradlew apiDump and commit the api file changes.

@nbransby nbransby merged commit 4c84afc into GitLiveApp:master Aug 19, 2025
96 of 97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ActionCodeSettings.linkDomain to firebase-auth for all platforms
3 participants