-
-
Notifications
You must be signed in to change notification settings - Fork 177
auth: suport ActionCodeSettings.linkDomain #733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I worked out a solution for my
Please let me know if there's anything I can do to help get this merged and released. Thanks again! |
happy for you to rebase yours and i will close mine otherwise: |
Platforms supported: * android * ios * js * NOT jvm
ec73ad5
to
cf894a3
Compare
@Reedyuk I just rebased on |
@nbransby are we ok to merge this in after updating the api check? |
@treitter - can you run ./gradlew apiDump and commit the api file changes. |
This adds the
ActionCodeSettings.linkDomain
property to support custom domains in auth (overridding the defaultPROJECT_ID.firebaseapp.com
authentication links).This PR should fix issue 731.
Supported platforms:
Unsupported platforms:
I haven't been able to test this since I haven't been able to resolve some issues with
mavenLocal
. But this is basically a copy-paste-edit ofdynamicLinkDomain
so it should work with, at most, trivial fixes.