Skip to content

Refactor Partial Path Queries #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions cpp/src/audit/templates/BackwardsPartialDataFlow.ql
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
/**
* @name Backwards Partial Dataflow
* @description Backwards Partial Dataflow
* @kind table
* @kind path-problem
* @precision low
* @problem.severity error
* @id githubsecuritylab/backwards-partial-dataflow
* @tags template
*/
Expand All @@ -27,8 +29,9 @@ private module MyFlow = TaintTracking::Global<MyConfig>; // or DataFlow::Global<

int explorationLimit() { result = 10 }

private module PartialFlow = MyFlow::FlowExploration<explorationLimit/0>;
private module PartialFlow = MyFlow::FlowExplorationRev<explorationLimit/0>;

from PartialFlow::PartialPathNode n, int dist
where PartialFlow::partialFlowRev(n, _, dist)
select dist, n
from PartialFlow::PartialPathNode source, PartialFlow::PartialPathNode sink
where PartialFlow::partialFlow(source, sink, _)
select sink.getNode(), source, sink, "This node receives taint from $@.", source.getNode(),
"this source"
13 changes: 8 additions & 5 deletions cpp/src/audit/templates/ForwardPartialDataflow.ql
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
/**
* @name Forward Partial Dataflow
* @description Forward Partial Dataflow
* @kind table
* @kind path-problem
* @precision low
* @problem.severity error
* @id githubsecuritylab/forward-partial-dataflow
* @tags template
*/
Expand All @@ -27,8 +29,9 @@ private module MyFlow = TaintTracking::Global<MyConfig>; // or DataFlow::Global<

int explorationLimit() { result = 10 }

private module PartialFlow = MyFlow::FlowExploration<explorationLimit/0>;
private module PartialFlow = MyFlow::FlowExplorationFwd<explorationLimit/0>;

from PartialFlow::PartialPathNode n, int dist
where PartialFlow::partialFlow(_, n, dist)
select dist, n
from PartialFlow::PartialPathNode source, PartialFlow::PartialPathNode sink
where PartialFlow::partialFlow(source, sink, _)
select sink.getNode(), source, sink, "This node receives taint from $@.", source.getNode(),
"this source"
4 changes: 2 additions & 2 deletions cpp/src/audit/templates/HoistSink.ql
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ private module MyFlow = TaintTracking::Global<MyConfig>; // or DataFlow::Global<

int explorationLimit() { result = 10 }

private module PartialFlow = MyFlow::FlowExploration<explorationLimit/0>;
private module PartialFlow = MyFlow::FlowExplorationRev<explorationLimit/0>;

from PartialFlow::PartialPathNode n, int dist
where
PartialFlow::partialFlowRev(n, _, dist) and
PartialFlow::partialFlow(n, _, dist) and
n.getNode() instanceof DataFlow::ParameterNode
select dist, n
13 changes: 8 additions & 5 deletions csharp/src/audit/templates/BackwardsPartialDataFlow.ql
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
/**
* @name Backwards Partial Dataflow
* @description Backwards Partial Dataflow
* @kind table
* @kind path-problem
* @precision low
* @problem.severity error
* @id githubsecuritylab/backwards-partial-dataflow
* @tags template
*/
Expand All @@ -27,8 +29,9 @@ private module MyFlow = TaintTracking::Global<MyConfig>; // or DataFlow::Global<

int explorationLimit() { result = 10 }

private module PartialFlow = MyFlow::FlowExploration<explorationLimit/0>;
private module PartialFlow = MyFlow::FlowExplorationRev<explorationLimit/0>;

from PartialFlow::PartialPathNode n, int dist
where PartialFlow::partialFlowRev(n, _, dist)
select dist, n
from PartialFlow::PartialPathNode source, PartialFlow::PartialPathNode sink
where PartialFlow::partialFlow(source, sink, _)
select sink.getNode(), source, sink, "This node receives taint from $@.", source.getNode(),
"this source"
13 changes: 8 additions & 5 deletions csharp/src/audit/templates/ForwardPartialDataflow.ql
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
/**
* @name Forward Partial Dataflow
* @description Forward Partial Dataflow
* @kind table
* @kind path-problem
* @precision low
* @problem.severity error
* @id githubsecuritylab/forward-partial-dataflow
* @tags template
*/
Expand All @@ -27,8 +29,9 @@ private module MyFlow = TaintTracking::Global<MyConfig>; // or DataFlow::Global<

int explorationLimit() { result = 10 }

private module PartialFlow = MyFlow::FlowExploration<explorationLimit/0>;
private module PartialFlow = MyFlow::FlowExplorationFwd<explorationLimit/0>;

from PartialFlow::PartialPathNode n, int dist
where PartialFlow::partialFlow(_, n, dist)
select dist, n
from PartialFlow::PartialPathNode source, PartialFlow::PartialPathNode sink
where PartialFlow::partialFlow(source, sink, _)
select sink.getNode(), source, sink, "This node receives taint from $@.", source.getNode(),
"this source"
4 changes: 2 additions & 2 deletions csharp/src/audit/templates/HoistSink.ql
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ private module MyFlow = TaintTracking::Global<MyConfig>; // or DataFlow::Global<

int explorationLimit() { result = 10 }

private module PartialFlow = MyFlow::FlowExploration<explorationLimit/0>;
private module PartialFlow = MyFlow::FlowExplorationRev<explorationLimit/0>;

from PartialFlow::PartialPathNode n, int dist
where
PartialFlow::partialFlowRev(n, _, dist) and
PartialFlow::partialFlow(n, _, dist) and
exists(Parameter p | n.getNode().asParameter() = p)
select dist, n
13 changes: 8 additions & 5 deletions go/src/audit/templates/BackwardsPartialDataFlow.ql
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
/**
* @name Backwards Partial Dataflow
* @description Backwards Partial Dataflow
* @kind table
* @kind path-problem
* @precision low
* @problem.severity error
* @id githubsecuritylab/backwards-partial-dataflow
* @tags template
*/
Expand All @@ -27,8 +29,9 @@ private module MyFlow = TaintTracking::Global<MyConfig>; // or DataFlow::Global<

int explorationLimit() { result = 10 }

private module PartialFlow = MyFlow::FlowExploration<explorationLimit/0>;
private module PartialFlow = MyFlow::FlowExplorationRev<explorationLimit/0>;

from PartialFlow::PartialPathNode n, int dist
where PartialFlow::partialFlowRev(n, _, dist)
select dist, n
from PartialFlow::PartialPathNode source, PartialFlow::PartialPathNode sink
where PartialFlow::partialFlow(source, sink, _)
select sink.getNode(), source, sink, "This node receives taint from $@.", source.getNode(),
"this source"
13 changes: 8 additions & 5 deletions go/src/audit/templates/ForwardPartialDataflow.ql
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
/**
* @name Forward Partial Dataflow
* @description Forward Partial Dataflow
* @kind table
* @kind path-problem
* @precision low
* @problem.severity error
* @id githubsecuritylab/forward-partial-dataflow
* @tags template
*/
Expand All @@ -27,8 +29,9 @@ private module MyFlow = TaintTracking::Global<MyConfig>; // or DataFlow::Global<

int explorationLimit() { result = 10 }

private module PartialFlow = MyFlow::FlowExploration<explorationLimit/0>;
private module PartialFlow = MyFlow::FlowExplorationFwd<explorationLimit/0>;

from PartialFlow::PartialPathNode n, int dist
where PartialFlow::partialFlow(_, n, dist)
select dist, n
from PartialFlow::PartialPathNode source, PartialFlow::PartialPathNode sink
where PartialFlow::partialFlow(source, sink, _)
select sink.getNode(), source, sink, "This node receives taint from $@.", source.getNode(),
"this source"
4 changes: 2 additions & 2 deletions go/src/audit/templates/HoistSink.ql
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ private module MyFlow = TaintTracking::Global<MyConfig>; // or DataFlow::Make<..

int explorationLimit() { result = 10 }

private module PartialFlow = MyFlow::FlowExploration<explorationLimit/0>;
private module PartialFlow = MyFlow::FlowExplorationRev<explorationLimit/0>;

from PartialFlow::PartialPathNode n, int dist
where
PartialFlow::partialFlowRev(n, _, dist) and
PartialFlow::partialFlow(n, _, dist) and
n.getNode() instanceof DataFlow::ParameterNode
select dist, n
11 changes: 6 additions & 5 deletions java/src/audit/templates/BackwardsPartialDataFlow.ql
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* @name Backwards Partial Dataflow
* @description Backwards Partial Dataflow
* @kind table
* @kind path-problem
* @id githubsecuritylab/backwards-partial-dataflow
* @tags template
*/
Expand All @@ -28,8 +28,9 @@ private module MyFlow = TaintTracking::Global<MyConfig>; // or DataFlow::Global<

int explorationLimit() { result = 10 }

private module PartialFlow = MyFlow::FlowExploration<explorationLimit/0>;
private module PartialFlow = MyFlow::FlowExplorationRev<explorationLimit/0>;

from PartialFlow::PartialPathNode n, int dist
where PartialFlow::partialFlowRev(n, _, dist)
select dist, n
from PartialFlow::PartialPathNode source, PartialFlow::PartialPathNode sink
where PartialFlow::partialFlow(source, sink, _)
select sink.getNode(), source, sink, "This node receives taint from $@.", source.getNode(),
"this source"
13 changes: 8 additions & 5 deletions java/src/audit/templates/ForwardPartialDataflow.ql
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
/**
* @name Forward Partial Dataflow
* @description Forward Partial Dataflow
* @kind table
* @kind path-problem
* @precision low
* @problem.severity error
* @id githubsecuritylab/forward-partial-dataflow
* @tags template
*/
Expand All @@ -28,8 +30,9 @@ private module MyFlow = TaintTracking::Global<MyConfig>; // or DataFlow::Global<

int explorationLimit() { result = 10 }

private module PartialFlow = MyFlow::FlowExploration<explorationLimit/0>;
private module PartialFlow = MyFlow::FlowExplorationFwd<explorationLimit/0>;

from PartialFlow::PartialPathNode n, int dist
where PartialFlow::partialFlow(_, n, dist)
select dist, n
from PartialFlow::PartialPathNode source, PartialFlow::PartialPathNode sink
where PartialFlow::partialFlow(source, sink, _)
select sink.getNode(), source, sink, "This node receives taint from $@.", source.getNode(),
"this source"
4 changes: 2 additions & 2 deletions java/src/audit/templates/HoistSink.ql
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,10 @@ private module MyFlow = TaintTracking::Global<MyConfig>; // or DataFlow::Global<

int explorationLimit() { result = 10 }

private module PartialFlow = MyFlow::FlowExploration<explorationLimit/0>;
private module PartialFlow = MyFlow::FlowExplorationRev<explorationLimit/0>;

from PartialFlow::PartialPathNode n, int dist
where
PartialFlow::partialFlowRev(n, _, dist) and
PartialFlow::partialFlow(n, _, dist) and
n.getNode() instanceof DataFlow::ExplicitParameterNode
select dist, n
13 changes: 8 additions & 5 deletions python/src/audit/templates/BackwardsPartialDataFlow.ql
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
/**
* @name Backwards Partial Dataflow
* @description Backwards Partial Dataflow
* @kind table
* @kind path-problem
* @precision low
* @problem.severity error
* @id githubsecuritylab/backwards-partial-dataflow
* @tags template
*/
Expand Down Expand Up @@ -32,8 +34,9 @@ private module MyFlow = TaintTracking::Global<MyConfig>; // or DataFlow::Global<

int explorationLimit() { result = 10 }

private module PartialFlow = MyFlow::FlowExploration<explorationLimit/0>;
private module PartialFlow = MyFlow::FlowExplorationRev<explorationLimit/0>;

from PartialFlow::PartialPathNode n, int dist
where PartialFlow::partialFlowRev(n, _, dist)
select dist, n
from PartialFlow::PartialPathNode source, PartialFlow::PartialPathNode sink
where PartialFlow::partialFlow(source, sink, _)
select sink.getNode(), source, sink, "This node receives taint from $@.", source.getNode(),
"this source"
13 changes: 8 additions & 5 deletions python/src/audit/templates/ForwardPartialDataflow.ql
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
/**
* @name Forward Partial Dataflow
* @description Forward Partial Dataflow
* @kind table
* @kind path-problem
* @precision low
* @problem.severity error
* @id githubsecuritylab/forward-partial-dataflow
* @tags template
*/
Expand Down Expand Up @@ -29,8 +31,9 @@ private module MyFlow = TaintTracking::Global<MyConfig>; // or DataFlow::Global<

int explorationLimit() { result = 10 }

private module PartialFlow = MyFlow::FlowExploration<explorationLimit/0>;
private module PartialFlow = MyFlow::FlowExplorationFwd<explorationLimit/0>;

from PartialFlow::PartialPathNode n, int dist
where PartialFlow::partialFlow(_, n, dist)
select dist, n
from PartialFlow::PartialPathNode source, PartialFlow::PartialPathNode sink
where PartialFlow::partialFlow(source, sink, _)
select sink.getNode(), source, sink, "This node receives taint from $@.", source.getNode(),
"this source"
4 changes: 2 additions & 2 deletions python/src/audit/templates/HoistSink.ql
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,10 @@ private module MyFlow = TaintTracking::Global<MyConfig>; // or DataFlow::Global<

int explorationLimit() { result = 10 }

private module PartialFlow = MyFlow::FlowExploration<explorationLimit/0>;
private module PartialFlow = MyFlow::FlowExplorationRev<explorationLimit/0>;

from PartialFlow::PartialPathNode n, int dist
where
PartialFlow::partialFlowRev(n, _, dist) and
PartialFlow::partialFlow(n, _, dist) and
n.getNode() instanceof DataFlow::ParameterNode
select dist, n
13 changes: 8 additions & 5 deletions ruby/src/audit/templates/BackwardsPartialDataFlow.ql
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
/**
* @name Backwards Partial Dataflow
* @description Backwards Partial Dataflow
* @kind table
* @kind path-problem
* @precision low
* @problem.severity error
* @id githubsecuritylab/backwards-partial-dataflow
* @tags template
*/
Expand All @@ -27,8 +29,9 @@ private module MyFlow = TaintTracking::Global<MyConfig>; // or DataFlow::Global<

int explorationLimit() { result = 10 }

private module PartialFlow = MyFlow::FlowExploration<explorationLimit/0>;
private module PartialFlow = MyFlow::FlowExplorationRev<explorationLimit/0>;

from PartialFlow::PartialPathNode n, int dist
where PartialFlow::partialFlowRev(n, _, dist)
select dist, n
from PartialFlow::PartialPathNode source, PartialFlow::PartialPathNode sink
where PartialFlow::partialFlow(source, sink, _)
select sink.getNode(), source, sink, "This node receives taint from $@.", source.getNode(),
"this source"
13 changes: 8 additions & 5 deletions ruby/src/audit/templates/ForwardPartialDataflow.ql
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
/**
* @name Forward Partial Dataflow
* @description Forward Partial Dataflow
* @kind table
* @kind path-problem
* @precision low
* @problem.severity error
* @id githubsecuritylab/forward-partial-dataflow
* @tags template
*/
Expand All @@ -27,8 +29,9 @@ private module MyFlow = TaintTracking::Global<MyConfig>; // or DataFlow::Global<

int explorationLimit() { result = 10 }

private module PartialFlow = MyFlow::FlowExploration<explorationLimit/0>;
private module PartialFlow = MyFlow::FlowExplorationFwd<explorationLimit/0>;

from PartialFlow::PartialPathNode n, int dist
where PartialFlow::partialFlow(_, n, dist)
select dist, n
from PartialFlow::PartialPathNode source, PartialFlow::PartialPathNode sink
where PartialFlow::partialFlow(source, sink, _)
select sink.getNode(), source, sink, "This node receives taint from $@.", source.getNode(),
"this source"
4 changes: 2 additions & 2 deletions ruby/src/audit/templates/HoistSink.ql
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ private module MyFlow = TaintTracking::Global<MyConfig>; // or DataFlow::Global<

int explorationLimit() { result = 10 }

private module PartialFlow = MyFlow::FlowExploration<explorationLimit/0>;
private module PartialFlow = MyFlow::FlowExplorationRev<explorationLimit/0>;

from PartialFlow::PartialPathNode n, int dist
where
PartialFlow::partialFlowRev(n, _, dist) and
PartialFlow::partialFlow(n, _, dist) and
n.getNode() instanceof DataFlow::ParameterNode
select dist, n