Simplified goFor implementation.#1
Merged
GiedriusS merged 1 commit intoGiedriusS:getForfrom May 27, 2019
Merged
Conversation
Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
Author
|
You awesome tests passes (: @GiedriusS |
GiedriusS
approved these changes
May 27, 2019
Owner
GiedriusS
left a comment
GiedriusS
left a comment
There was a problem hiding this comment.
This is smart, how have I not thought of this? 👍 awesome
Author
|
I think you were focused on fixing just this last piece. Always try to think in bigger picture, sometimes going back and rethinking bigger piece is easier then workaround details (: |
GiedriusS
added a commit
that referenced
this pull request
Jun 13, 2022
* removed gogo-proto extensions from rpc.proto Signed-off-by: rahulii <r.sawra@gmail.com> * store: convert to a slice of pointers Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * removed gogoproto specific extensions and generated code * removed Zlabel custom type and ran make proto Signed-off-by: rahulii <r.sawra@gmail.com> * labelpb: update functions to not use ZLabels Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * store: convert chunks to pointers Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * *: convert to use *labelpb.Label Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * resolve errors * make use of custom json tag * more changes and resolve errors * store: convert more places to use pointers Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * replaced gogo-json-tag with protoc-go-inject-tag * scripts/genproto: add hack for protobuf types Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * convert time.Time to protobuf.Timestamp * migrate time.Time to protobuf.Timestamp * resolving tests error * resolve tests errors * implement custom MarshalJSON * partial fix to tests * fix to tests * fix to tests * fix to more tests * rules: make tests clearer Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * rulespb: fix some timestamp stuff Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * api: reuse same function, fix tests Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * rules: use proper default value for Timestamp Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * fix to tests * fix tests * metadata: fix tests Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * *: remove unused files Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> * e2e: fix more timestamp problems Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com> Co-authored-by: rahulii <r.sawra@gmail.com> Co-authored-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
GiedriusS
pushed a commit
that referenced
this pull request
Jul 11, 2023
…-func Reuse buffers for label comparison
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bartek Plotka bwplotka@gmail.com