Remove MagicValues #725
Merged
Remove MagicValues #725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This does also contain a few miscellaneous fixes/cleanups, which can be removed and their own PR made. |
Camotoy
reviewed
Feb 22, 2023
src/main/java/com/github/steveice10/mc/protocol/codec/MinecraftCodecHelper.java
Outdated
Show resolved
Hide resolved
src/main/java/com/github/steveice10/mc/protocol/data/game/inventory/ClickItemAction.java
Outdated
Show resolved
Hide resolved
src/main/java/com/github/steveice10/mc/protocol/data/game/inventory/CreativeGrabAction.java
Outdated
Show resolved
Hide resolved
...veice10/mc/protocol/packet/ingame/serverbound/inventory/ServerboundContainerClickPacket.java
Outdated
Show resolved
Hide resolved
|
Thanks for the review, will get on these asap 🙂 |
Camotoy
approved these changes
Feb 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to push directly to this branch or make a pr with any changes.