Making sdk compatible with RN 0.60 #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishalnarkhede
force-pushed
the
vishal/compatible-with-rn-60
branch
from
02e43d1 to
c6cd9b9
Compare
vishalnarkhede
force-pushed
the
vishal/compatible-with-rn-60
branch
from
cf84585 to
d17fedd
Compare
jaapbakker88
approved these changes
Aug 26, 2019
…e into vishal/compatible-with-rn-60
vishalnarkhede
force-pushed
the
vishal/compatible-with-rn-60
branch
from
42a2570 to
c0f7b1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submit a pull request
CLA
Description of the pull request
React native introduced autolinking behaviour, so packages don't need to be linked manually. And RN does this using cocoapod. All the dependencies are auto-linked according to their pod configuration. But for this to work, we need to have cocoapods configured for our project. So that, when consumer installs our SDK, then pods of dependencies of our sdk will also be installed on his end when he does
pod install. But our project is kind of pure js project ... we don't really have any ios/android directories.So either we can make it native project (with ios/android directories). But I don't think it makes sense, since we don't really have any native code.
Other option is to take following dependencies out of our project and ask consumer to install it on their end (on application level).
I am opting for option 2. This is something similar what
react-navigationlibrary has done as well. They also have pure-js library for react-native. Thus to support RN 0.60, they separated outreact-native-gesture-handler.TODO: Currently testing things for android.
Update
Works fine for andoirdX after using jetifier