Modified continental COG mosaics submodule to contain colour schemes for VRTs #1368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GL-S
requested review from
robbibt,
BexDunn,
erialC-P,
Kooie-cate,
geoscience-aman,
JM-GA,
margaretharrison,
vnewey,
Ariana-B and
supermarkion
as code owners
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
GL-S
requested review from
cbur24,
LaurenSchenk1,
jennaguffogg and
colourmeamused
as code owners
robbibt
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the colour schemes were in
Supplementary materials. It worked fine within the sandbox, but not if dea-tools was installed and used outside of it.Now the colour schemes are contained and extracted from a python script (inside the module) with all styling dictionaries, rather than individual json files.
It is still possible to use a custom colour scheme by providing the path to a json file structured similarly to a python dictionary. I have mentioned this functionality in the example notebook and expanded the usage explanation in the functions and CLI descriptions. I have not included a practical demonstration in the notebook for sake of brevity, but I have tested it and worked well.