Refactor to use eo-tides tide modelling tools
#1357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
robbibt
changed the title
eo-tides tide modelling tools
robbibt
requested review from
BexDunn,
erialC-P,
uchchwhash,
Kooie-cate,
geoscience-aman,
JM-GA,
Ariana-B,
amanda2099,
supermarkion and
erin-telfer
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR finally updates DEA Notebooks to use tide modelling functions from
eo-tides, and fully deprecates old outdated tools fromdea_tools.coastal:eo-tidesas a DEA Tools package requirementdea_tools.coastalfunctions and add error if user tries to import themTidal_modelling.ipynb,Coastal_erosion.ipynbandIntertidal_elevation.ipynbto useeo-tidesOther:
DEA_High_and_Low_Tide_Imagery.ipynbnotebook until we can update it to use the new DEA Tidal Composites product (we can retrieve it from Git history)