Apply Ruff code formatting and linting to entire DEA Tools #1356
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This pull request does a major reformat of our DEA Tools code, aimed to standardise our code and clear up any major code isues. I've used
Ruff
(https://docs.astral.sh/ruff/) to do this, running the following code formatting and code linting commands to automatically update code:These commands make changes like:
These commands are theoretically safe (e.g. designed to not break code), but it's a bit hard to tell as we don't have complete unit testing in DEA Tools. We're likely going to have to rely heavily on the Jupyter Notebooks integration tests to see if any notebooks break after the change.