Skip to content

Conversation

cbur24
Copy link
Collaborator

@cbur24 cbur24 commented Jun 27, 2025

Proposed changes

ML notebooks and classification tools reviewed and updated to use odc-geo based tools, in anticipaion of the ODC 1.9 upgrade. Along with minor revisions to the notebooks where stuff was broken. There is an ongoing issue with predict_xr where per-class probabilities fail when using dask. I will return to this issue in the future, for now the ML notebooks are working.

Checklist

If this is a notebook, then have you:

  • Checked the structure of the notebook follows our DEA-notebooks template
  • Removed any unused Python packages from Load packages
  • Removed any unused/empty code cells
  • Removed any guidance cells (e.g. General advice)
  • Ensured that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended).
  • Included relevant tags in the final notebook cell (refer to the DEA Tags Index, and re-use tags if possible)
  • Tested notebook on the DEA Sandbox
  • Cleared all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated
  • If applicable, update the Notebook currently compatible with line below the notebook title to reflect the environments the notebook is compatible with
  • Check for any spelling mistakes using the DEA Sandbox's built-in spellchecker (double click on markdown cells then right-click on pink highlighted words). For example:

sandbox_spellchecker

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@robbibt
Copy link
Member

robbibt commented Jul 9, 2025

Hey @cbur24, I can see the tests failing here - seems like a simple issue of a missing import, is this something you're able to fix?

Copy link
Member

@robbibt robbibt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic, thanks @cbur24! Really nice to update to odc.geo here, should make future upgrades much easier.

@robbibt robbibt merged commit fd6db98 into develop Jul 9, 2025
7 checks passed
@robbibt robbibt deleted the update_classification_tools branch July 9, 2025 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants