Skip to content

Conversation

cbur24
Copy link
Collaborator

@cbur24 cbur24 commented Apr 15, 2025

Proposed changes

I've found the substantial number of print statements in load_ard to be frustrating at times, especially when wrapping the code in a multiprocessing loop. So I've added a verbose= parameter so the user can decide if they want the print statements or not.
Tested by re-running the Using_load_ard notebook to ensure it didn't break any functionality, but haven't changed that notebook in any way.

Checklist

If this is a notebook, then have you:

  • Checked the structure of the notebook follows our DEA-notebooks template
  • Removed any unused Python packages from Load packages
  • Removed any unused/empty code cells
  • Removed any guidance cells (e.g. General advice)
  • Ensured that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended).
  • Included relevant tags in the final notebook cell (refer to the DEA Tags Index, and re-use tags if possible)
  • Tested notebook on the DEA Sandbox
  • Cleared all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated
  • If applicable, update the Notebook currently compatible with line below the notebook title to reflect the environments the notebook is compatible with
  • Check for any spelling mistakes using the DEA Sandbox's built-in spellchecker (double click on markdown cells then right-click on pink highlighted words). For example:

sandbox_spellchecker

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@erialC-P erialC-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! The logic all looks good to me. Maybe wait to merge until the tests have finished running first?

@cbur24
Copy link
Collaborator Author

cbur24 commented Apr 16, 2025

Thanks for reviewing @erialC-P!

@cbur24 cbur24 merged commit 20e3bb0 into develop Apr 16, 2025
7 checks passed
@cbur24 cbur24 deleted the update_loadard branch April 16, 2025 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants