Skip to content

Add new argument to createStaticMemberType #2818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

Flakebi
Copy link
Member

@Flakebi Flakebi commented Nov 15, 2023

Makes llpc compatible with the change in
llvm/llvm-project#72234

@amdvlk-admin
Copy link

dc68085 Jenkins build error.
/jenkins/workspace/vulkan/sanitized-opensource/Github-PR/llpc-github-pr/driver_build/drivers/llpc/lgc/patch/VertexFetch.cpp:1538:78: error: reference to ‘Builder’ is ambiguous
1538 | builderImpl.getInt32(0), Builder::BufferFlagAddress);
| ^~~~~~~
In file included from /jenkins/workspace/vulkan/sanitized-opensource/Github-PR/llpc-github-pr/driver_build/drivers/llpc/lgc/include/lgc/builder/BuilderImpl.h:33,
from /jenkins/workspace/vulkan/sanitized-opensource/Github-PR/llpc-github-pr/driver_build/drivers/llpc/lgc/include/lgc/patch/VertexFetch.h:34,
from /jenkins/workspace/vulkan/sanitized-opensource/Github-PR/llpc-github-pr/driver_build/drivers/llpc/lgc/patch/VertexFetch.cpp:31:

/jenkins/workspace/vulkan/sanitized-opensource/Github-PR/llpc-github-pr/driver_build/drivers/llpc/lgc/patch/VertexFetch.cpp:1546:77: error: reference to ‘Builder’ is ambiguous
1546 | builderImpl.getInt32(binding), Builder::BufferFlagNonConst);
| ^~~~~~~
In file included from /jenkins/workspace/vulkan/sanitized-opensource/Github-PR/llpc-github-pr/driver_build/drivers/llpc/lgc/include/lgc/builder/BuilderImpl.h:33,
from /jenkins/workspace/vulkan/sanitized-opensource/Github-PR/llpc-github-pr/driver_build/drivers/llpc/lgc/include/lgc/patch/VertexFetch.h:34,
from /jenkins/workspace/vulkan/sanitized-opensource/Github-PR/llpc-github-pr/driver_build/drivers/llpc/lgc/patch/VertexFetch.cpp:31:

@amdvlk-admin
Copy link

Test summary for commit 12f44aa

CTS tests (Failed: 0/138443)
  • Built with version 1.3.5.2
  • Ubuntu navi3x, Srdcvk
    • Passed: 35211/69228 (50.9%)
    • Failed: 0/69228 (0.0%)
    • Not Supported: 34017/69228 (49.1%)
    • Warnings: 0/69228 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 35241/69215 (50.9%)
    • Failed: 0/69215 (0.0%)
    • Not Supported: 33974/69215 (49.1%)
    • Warnings: 0/69215 (0.0%)

@Flakebi Flakebi merged commit b91f572 into GPUOpen-Drivers:dev Nov 16, 2023
@Flakebi Flakebi deleted the merge branch November 16, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants