Fixing missing bibtex_source, and created BibTeXSource enum

[jamesbraza]

• Created a BibTeXSource enum to help people understand possible values
• Fixed bibtex_source not being present in vanilla DocDetails
  • bibtex_source, introduced in Add Client (external API) Module For Enhanced Metadata #306, I think just missed this branch

[Copilot]

Pull Request Overview

Adds a new BibTeXSource enum to track where BibTeX entries originate and ensures bibtex_source is included in the other field of DocDetails.

• Introduce BibTeXSource enum and its helper method update_other
• Refactor populate_bibtex_key_citation to use the new enum
• Update clients and tests to populate bibtex_source via enum values

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
tests/test_paperqa.py	Updated test to expect "bibtex_source": ["self_generated"]
paperqa/types.py	Added BibTeXSource enum and refactored bibtex metadata logic
paperqa/clients/semantic_scholar.py	Switched hardcoded strings to BibTeXSource enum values
paperqa/clients/crossref.py	Switched hardcoded strings to BibTeXSource enum values

Comments suppressed due to low confidence (4)

paperqa/types.py:348

• The new update_other helper logic isn’t directly tested; consider adding unit tests for scenarios with no existing other, with an existing list missing the source, and with the source already present.

    def update_other(self, other: dict[str, Any] | None = None) -> dict[str, Any]:

paperqa/clients/semantic_scholar.py:154

• [nitpick] Storing the raw enum .value bypasses type safety; consider passing the enum member itself and converting to string only at serialization boundary.

    bibtex_source = BibTeXSource.SELF_GENERATED.value

paperqa/clients/crossref.py:170

• [nitpick] Consistent with the previous suggestion, using .value here loses the benefit of the enum; consider carrying the enum through until final serialization.

    bibtex_source = BibTeXSource.SELF_GENERATED.value

paperqa/types.py:588

• You removed the # noqa: PLR0912 comment but the method is still very long and nested; consider re-adding the noqa or refactoring to satisfy complexity rules.

    def populate_bibtex_key_citation(cls, data: dict[str, Any]) -> dict[str, Any]: