Expanded test_chain_completion to check IDs and text
#944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbraza
requested review from
sremo,
mskarlin,
maykcaldas,
ludomitch and
nadolskit
dosubot
bot
added
the
size:S
There was a problem hiding this comment.
Pull Request Overview
This PR expands the test_chain_completion test to provide a more detailed failure mode breakdown for the newer litellm behavior.
- Added import for UUID to enable type-checking of completion IDs
- Changed messages initialization to a one-line list and added assertions to verify both the UUID type of the response and that subsequent responses have unique IDs
- Updated assertions to check text and token timing behaviors
nadolskit
approved these changes
May 5, 2025
jamesbraza
force-pushed
the
more-verbose-test-chain-completion
branch
2 times, most recently
from
0495b90 to
951dbc4
Compare
jamesbraza
force-pushed
the
more-verbose-test-chain-completion
branch
from
951dbc4 to
364d13a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer
litellmbroke this test, so I am expanding it first so we have a better failure mode breakdown.