Fixed README typo on basename
#927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbraza
requested review from
whitead,
sremo,
mskarlin,
maykcaldas,
ludomitch and
nadolskit
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a typo in the README by replacing an incorrect function call with the correct one.
- Corrected the usage from os.path.name(f) to os.path.basename(f)
- Ensured the code example properly demonstrates extracting the basename of a file
dosubot
bot
added
size:XS
whitead
approved these changes
Mar 30, 2025
jamesbraza
force-pushed
the
fixed-readme
branch
from
b9733d9 to
622f36d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See PR title