Skip to content

Removed LFRQA prompts #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2025
Merged

Removed LFRQA prompts #923

merged 1 commit into from
Mar 29, 2025

Conversation

jamesbraza
Copy link
Collaborator

Future-House/aviary#191 correctly propagated these prompts to aviary, but #872 missed their removal here.

@jamesbraza jamesbraza added the bug Something isn't working label Mar 29, 2025
@jamesbraza jamesbraza self-assigned this Mar 29, 2025
@Copilot Copilot AI review requested due to automatic review settings March 29, 2025 00:56
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 29, 2025
Copilot
Copilot AI reviewed Mar 29, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request removes LFRQA prompt definitions from paperqa/prompts.py to align with changes in the corresponding aviary removal PR.

  • Removed block defining lfrqa_system_prompt.
  • Removed block defining lfrqa_prompt_template.

maykcaldas
maykcaldas approved these changes Mar 29, 2025
View reviewed changes
Copy link
Collaborator

@maykcaldas maykcaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 29, 2025
@jamesbraza jamesbraza merged commit 380d0de into main Mar 29, 2025
4 of 5 checks passed
@jamesbraza jamesbraza deleted the removing-lfrqa-sys-prompt branch March 29, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@maykcaldas maykcaldas maykcaldas approved these changes

@sremo sremo Awaiting requested review from sremo

@mskarlin mskarlin Awaiting requested review from mskarlin

@ludomitch ludomitch Awaiting requested review from ludomitch

Assignees

@jamesbraza jamesbraza

Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesbraza @maykcaldas