Skip to content

Conversation

jamesbraza
Copy link
Collaborator

We used to always compute the filehash twice, now it's just once.

@jamesbraza jamesbraza self-assigned this Aug 25, 2025
@Copilot Copilot AI review requested due to automatic review settings August 25, 2025 21:02
@jamesbraza jamesbraza added the enhancement New feature or request label Aug 25, 2025
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working labels Aug 25, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR eliminates duplicate computation of filehash for document bodies by passing the computed hash value between methods instead of recomputing it.

  • Modified filecheck method to accept a pre-computed filehash instead of the body string
  • Removed redundant filehash computation in the add_document method
  • Updated variable naming from filehash to body_filehash for clarity

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 25, 2025
@jamesbraza jamesbraza merged commit a75dd8c into main Aug 25, 2025
5 checks passed
@jamesbraza jamesbraza deleted the less-filehash branch August 25, 2025 21:48
Copy link

dosubot bot commented Aug 25, 2025

Documentation updates
Checked 1 published document(s). No updates required.

How did I do? Any feedback?  Join Discord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants