Fixed SearchIndex default index_directory being a default_factory
#1070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbraza
requested review from
whitead,
mskarlin,
maykcaldas,
SamCox822 and
nadolskit
dosubot
bot
added
the
size:S
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the SearchIndex class where the index_directory parameter was incorrectly accessing a default factory function instead of calling it to get the actual default value.
- Removes the direct access to the default factory and adds proper handling for None values
- Adds explicit type casting and function call to retrieve the default directory path
- Updates type annotation to include None as a valid input type
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
whitead
approved these changes
Aug 21, 2025
|
Documentation updates How did I do? Any feedback? |
jamesbraza
added a commit
that referenced
this pull request
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We needed to call a default factory, not pass a default