-
Notifications
You must be signed in to change notification settings - Fork 770
Consolidating on httpx
#1062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Consolidating on httpx
#1062
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR consolidates HTTP client libraries by replacing aiohttp
with httpx
throughout the repository to achieve a single, unified HTTP client approach.
- Replace
aiohttp.ClientSession
withhttpx.AsyncClient
across all test files - Update exception handling from
aiohttp.ClientResponseError
tohttpx.HTTPStatusError
- Refresh test cassettes with new HTTP request headers and formatting changes from the httpx client
Reviewed Changes
Copilot reviewed 41 out of 51 changed files in this pull request and generated no comments.
File | Description |
---|---|
tests/test_clinical_trials.py | Updates test fixtures and mocks to use httpx instead of aiohttp for clinical trials API testing |
tests/test_clients.py | Replaces aiohttp.ClientSession with httpx.AsyncClient in metadata client tests and updates citation count test data |
tests/cassettes/*.yaml | Updates VCR cassettes with new request headers and response formatting from httpx instead of aiohttp |
e04ddb9
to
0d51fd6
Compare
Why the rename? Won't that break backwards compatibility? |
You mean rename from
I thought the name change was good because:
|
0d51fd6
to
324a5a3
Compare
324a5a3
to
008e269
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
cbf01a2
to
d383e5a
Compare
db9614d
to
d0ef74f
Compare
d0ef74f
to
90162b3
Compare
Before:
aiohttp
andhttpx
coexisted in this repoAfter: we just have
httpx