Removed dead patch from test_add_clinical_trials_to_docs
#1056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
There was a problem hiding this comment.
Pull Request Overview
This PR removes a dead patch decorator and consolidates mock object creation in the test_add_clinical_trials_to_docs test function. The changes simplify the test setup while maintaining the same test functionality.
- Removed unused
patchdecorator forsearch_retrieve_clinical_trialsfunction - Consolidated mock object creation using more concise syntax
- Updated fixture naming to follow pytest conventions
jamesbraza
force-pushed
the
cleaning-up-clin-trials-test
branch
from
d229f23 to
c600987
Compare
mskarlin
approved these changes
Aug 11, 2025
nadolskit
approved these changes
Aug 11, 2025
jamesbraza
added a commit
that referenced
this pull request
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also consolidate some of the
Mockcreation code