Expose answer evidence score cutoff as config #1031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:S
There was a problem hiding this comment.
Pull Request Overview
This PR exposes the answer evidence score cutoff as a configurable parameter instead of using a hardcoded value of 0. Previously, the evidence filtering was hardcoded to only include contexts with a score greater than 0.
- Added
evidence_relevance_score_cutofffield toAnswerSettingsconfiguration - Updated evidence filtering logic to use the configurable cutoff instead of hardcoded value
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/paperqa/settings.py | Adds new evidence_relevance_score_cutoff configuration field with default value of 0 |
| src/paperqa/docs.py | Updates filtering logic to use configurable cutoff instead of hardcoded value |
jamesbraza
reviewed
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was hard coded previously