Removed extra test test_can_read_normal_pdf_reader

[jamesbraza]

• test_can_read_normal_pdf_reader was a subset of test_fileio_reader_pdf
• Named some pytest fixtures so pylint can not report name collisions

[Copilot]

Pull Request Overview

This PR cleans up test code by removing a redundant test function and addressing pylint warnings about fixture naming. The removed test test_can_read_normal_pdf_reader was identified as being a subset of existing test coverage in test_fileio_reader_pdf.

• Removed duplicate test function test_can_read_normal_pdf_reader
• Added explicit names to pytest fixtures to prevent pylint name collision warnings
• Minor code reorganization in test_fileio_reader_pdf

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
tests/test_paperqa.py	Removed redundant test function, renamed fixture function, and minor reordering
tests/conftest.py	Added explicit names to pytest fixtures and renamed fixture functions

Comments suppressed due to low confidence (4)

tests/test_paperqa.py:70

• [nitpick] The function name 'fixture_docs_fixture' is redundant and unclear. Consider renaming to 'create_docs' or 'docs_with_paper' to better describe what the fixture provides.

async def fixture_docs_fixture(stub_data_dir: Path) -> Docs:

tests/conftest.py:68

• [nitpick] The function name 'fixture_tmp_path_cleanup' is redundant. Consider renaming to 'tmp_path_with_cleanup' or 'auto_cleanup_tmp_path' to better describe the fixture's behavior.

def fixture_tmp_path_cleanup(tmp_path: Path) -> Iterator[Path]:

tests/conftest.py:76

• [nitpick] The function name 'fixture_agent_home_dir' is redundant. Consider renaming to 'setup_agent_home_dir' or 'agent_home_with_env' to better describe the fixture's purpose.

def fixture_agent_home_dir(

tests/conftest.py:85

• [nitpick] The function name 'fixture_agent_index_dir' is redundant. Consider renaming to 'get_agent_index_dir' or 'agent_index_path' to better describe what the fixture returns.

def fixture_agent_index_dir(agent_home_dir: Path) -> Path: