Adding variable timeouts for clients #1015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
There was a problem hiding this comment.
Pull Request Overview
This PR addresses timeout issues with external API clients by making timeout values configurable through environment variables and increasing default timeout values. The changes ensure that clients can handle slower API responses, particularly from Crossref.
- Updates default timeout values from 5.0/10.0 seconds to a configurable 10.0 seconds default
- Makes timeout values configurable via environment variables for each client
- Converts hardcoded timeout constants to dynamically loaded values from environment
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| paperqa/clients/crossref.py | Updates timeout from 5.0 to configurable 10.0 seconds via CROSSREF_API_REQUEST_TIMEOUT environment variable |
| paperqa/clients/openalex.py | Updates timeout from 5.0 to configurable 10.0 seconds via OPENALEX_API_REQUEST_TIMEOUT environment variable |
| paperqa/clients/semantic_scholar.py | Makes existing 10.0 second timeout configurable via SEMANTIC_SCHOLAR_API_REQUEST_TIMEOUT environment variable |
whitead
approved these changes
Jul 18, 2025
nadolskit
approved these changes
Jul 18, 2025
jamesbraza
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our default timeouts were not long enough for Crossref. This ups the default and makes it a configurable variable.