Update-Skript löscht Plugins, alte Assets und config #142
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements an update script that cleans up legacy components during the bloecks addon update process. The script removes deprecated plugins, old assets, and configuration data when upgrading from versions prior to 5.0.0.
- Removes three legacy plugins (status, cutncopy, dragndrop) from the bloecks addon
- Deletes old addon assets to prevent conflicts
- Cleans up configuration namespace for pre-5.0.0 versions
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| rex_dir::delete(rex_path::addonAssets('bloecks')); | ||
|
|
||
| if (version_compare(rex_addon::get('bloecks')->getVersion(), '5.0.0', '<')) { |
There was a problem hiding this comment.
The version comparison logic is inverted. This condition will be true for versions >= 5.0.0, not < 5.0.0 as intended. The comparison operator should be '<' and the logic should check if the current version is less than 5.0.0.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
@skerbis das Feedback von Copilot ist doch falsch, oder? Habe ich einen Knick in der Optik?
#141