Skip to content

feat: Add segment page #5895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat: Add segment page #5895

wants to merge 8 commits into from

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Aug 5, 2025 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Moves editing a segment to a new page.

image
  • Minor: Improves the breadcrumb component.
    Before:
image

After:

image

How did you test this code?

Created / edited segments + E2E

@kyle-ssg kyle-ssg requested a review from a team as a code owner August 5, 2025 15:30
@kyle-ssg kyle-ssg requested review from tiagoapolo and removed request for a team August 5, 2025 15:30
@vercel Vercel
Copy link

vercel bot commented Aug 5, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs Ready Ready Preview Comment Aug 29, 2025 9:16am
flagsmith-frontend-preview Ready Ready Preview Comment Aug 29, 2025 9:16am
flagsmith-frontend-staging Ready Ready Preview Comment Aug 29, 2025 9:16am

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard feature New feature or request labels Aug 5, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5895 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5895 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5895 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-5895 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5895 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-5895 Finished ✅ Results ✅

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Aug 5, 2025
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Aug 5, 2025
Zaimwa9
Zaimwa9 requested changes Aug 26, 2025
View reviewed changes
Copy link
Contributor

@Zaimwa9 Zaimwa9 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, liking it more this way.
Just:

  • One typo in a class
  • Suggestion about the conditions form
  • One bug related to navigation

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Aug 26, 2025
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Aug 26, 2025
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Aug 26, 2025
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Aug 27, 2025
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zaimwa9 Zaimwa9 Zaimwa9 requested changes

@tiagoapolo tiagoapolo Awaiting requested review from tiagoapolo tiagoapolo is a code owner automatically assigned from Flagsmith/flagsmith-front-end

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
feature New feature or request front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kyle-ssg @Zaimwa9 @matthewelwell