Skip to content

feat: move tui code to tui package#591

Closed
brianmcgee wants to merge 1 commit into
FiloSottile:mainfrom
brianmcgee:feat/sops-integration
Closed

feat: move tui code to tui package#591
brianmcgee wants to merge 1 commit into
FiloSottile:mainfrom
brianmcgee:feat/sops-integration

Conversation

@brianmcgee

Copy link
Copy Markdown

It makes PluginTerminalUI available for sops (and other third parties) to support plugins more easily.

@felixfontein

Copy link
Copy Markdown

From the SOPS point of view, having this as a reusable package would be really great! Basically copy'n'pasting that code over (and keeping it up-to-date) would IMO be a last-resort solution, which I'd like to avoid.

@Mic92

Mic92 commented Oct 12, 2024

Copy link
Copy Markdown

CI needs a fix:

Error: cmd/age-keygen/keygen.go:161:13: non-constant format string in call to log.Printf

@0x2b3bfa0

This comment has been minimized.

@brianmcgee

Copy link
Copy Markdown
Author

I missed that the static checks needed to be fixed. I just cherry-picked #589 into this branch.

@FiloSottile, it would be great if we could get this merged 🙏

@pheiduck pheiduck mentioned this pull request Oct 21, 2024
@Mic92

Mic92 commented Nov 9, 2024

Copy link
Copy Markdown

Friendly ping

@Mic92

Mic92 commented Nov 29, 2024

Copy link
Copy Markdown

I guess a long-term fork, it is than. Someone else interested in maintaining it? We could create some org that contains both age and sops with this feature. We would probably just need to merge with upstream every once in a while.

@felixfontein

Copy link
Copy Markdown

@FiloSottile any kind of feedback (like whether this has a chance of eventually getting merged) would be great!

@visualphoenix

Copy link
Copy Markdown

+1 would be great to have this merged

@NovaViper

Copy link
Copy Markdown

@brianmcgee hey looks like #589 just got merged!

Makes PluginTerminalUI available for sops (and other third parties) so they can more easily support plugins.
@tahlonbrahic

Copy link
Copy Markdown

@Mic92 I will be maintaining a fork from this PR if anyone else is interested.

@Enzime

Enzime commented Jan 15, 2025

Copy link
Copy Markdown

I’ve merged this PR at https://github.com/age-sops/age

Feel free to make PRs with any improvements you have

FiloSottile added a commit that referenced this pull request Dec 24, 2025
Closes #611
Closes #591

Co-authored-by: Nicolas Dumazet <nicdumz.commits@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants