-
Notifications
You must be signed in to change notification settings - Fork 463
Replace apt-key
#5491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Replace apt-key
#5491
Conversation
Signed-off-by: Josh Soref <[email protected]>
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
build/ferretdb-bw/Dockerfile
Outdated
|
||
curl -L https://pgp.mongodb.com/server-7.0.asc | apt-key add - | ||
echo "deb [ arch=amd64,arm64 ] https://repo.mongodb.org/apt/debian bookworm/mongodb-org/7.0 main" | tee /etc/apt/sources.list.d/mongodb-org-7.0.list | ||
curl -L https://pgp.mongodb.com/server-7.0.asc | \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those commands followed https://www.mongodb.com/docs/mongodb-shell/install/, but the instructions on that page a just broken now; for example, "If you receive an error indicating that gnupg is not installed" is just not possible.
I guess we have to do our own now.
build/ferretdb-bw/Dockerfile
Outdated
curl -L https://pgp.mongodb.com/server-7.0.asc | apt-key add - | ||
echo "deb [ arch=amd64,arm64 ] https://repo.mongodb.org/apt/debian bookworm/mongodb-org/7.0 main" | tee /etc/apt/sources.list.d/mongodb-org-7.0.list | ||
curl -L https://pgp.mongodb.com/server-7.0.asc | \ | ||
gpg --dearmor --yes --output /usr/share/keyrings/mongodb-bookworm.gpg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We generally indent lines that follow \
with a tab. Please do so in that and other changed files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have an example? I can't find one in the repository and VS Code wants to convert <tab>
into two spaces. I can't tell if you want an actual tab, two spaces, four spaces, or eight spaces.
Signed-off-by: Josh Soref <[email protected]>
801eb7d
to
b7d5c68
Compare
Description
Replace
apt-key
(and fixbuild/ferretdb-bw/Dockerfile
to build...)Readiness checklist
task all
, and it passed.@FerretDB/core
), Milestone (Next
), Labels, Project and project's Sprint fields.