-
-
Notifications
You must be signed in to change notification settings - Fork 180
Deprecate MissingKotlinParameterException and replace with new exception #1025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the deprecated MissingKotlinParameterException
and replaces it with a new KotlinInvalidNullException
to provide better error handling for null/missing Kotlin parameters. This addresses issue #617 and modernizes the exception handling in the Jackson Kotlin module.
- Introduces a new
KotlinInvalidNullException
class that extendsInvalidNullException
- Updates the deprecation level of
MissingKotlinParameterException
from WARNING to ERROR - Replaces all usages of the old exception with the new one across test files and core instantiation logic
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
KotlinInvalidNullException.java | New exception class that provides Kotlin-specific property name handling and extends InvalidNullException |
KotlinValueInstantiator.kt | Updates exception throwing logic to use the new KotlinInvalidNullException instead of MissingKotlinParameterException |
Exceptions.kt | Updates deprecation metadata for MissingKotlinParameterException to ERROR level and points to the new replacement |
KotlinInvalidNullExceptionTest.kt | New test file to verify the behavior of KotlinInvalidNullException with property name handling |
Github168.kt | Updates test to expect the new exception type |
NullToDefaultTests.kt | Updates test to expect the new exception type |
wrt: #617 (comment)
closes #617