Skip to content

Conversation

k163377
Copy link
Contributor

@k163377 k163377 commented Jul 27, 2025

wrt: #617 (comment)
closes #617

@k163377 k163377 requested a review from Copilot July 27, 2025 13:20
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the deprecated MissingKotlinParameterException and replaces it with a new KotlinInvalidNullException to provide better error handling for null/missing Kotlin parameters. This addresses issue #617 and modernizes the exception handling in the Jackson Kotlin module.

  • Introduces a new KotlinInvalidNullException class that extends InvalidNullException
  • Updates the deprecation level of MissingKotlinParameterException from WARNING to ERROR
  • Replaces all usages of the old exception with the new one across test files and core instantiation logic

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
KotlinInvalidNullException.java New exception class that provides Kotlin-specific property name handling and extends InvalidNullException
KotlinValueInstantiator.kt Updates exception throwing logic to use the new KotlinInvalidNullException instead of MissingKotlinParameterException
Exceptions.kt Updates deprecation metadata for MissingKotlinParameterException to ERROR level and points to the new replacement
KotlinInvalidNullExceptionTest.kt New test file to verify the behavior of KotlinInvalidNullException with property name handling
Github168.kt Updates test to expect the new exception type
NullToDefaultTests.kt Updates test to expect the new exception type

@k163377 k163377 changed the title Remove MissingKotlinParameterException and replace with new exception Deprecate MissingKotlinParameterException and replace with new exception Jul 27, 2025
@k163377 k163377 merged commit 80b8371 into FasterXML:2.x Aug 3, 2025
15 checks passed
@k163377 k163377 deleted the ex branch August 3, 2025 03:55
k163377 added a commit to ProjectMapK/jackson-module-kogera that referenced this pull request Aug 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove MissingKotlinParameterException and replace with sub class of InvalidNullException
1 participant