Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see the disabled test fail in 2.19, 2.18 and 2.17 branches and the enabled test pass on all 3 branches but this could be an issue on my side.
#5011 shows the 'failing' test fails in 2.17 branch and the passing test passes - so 2.17 and 2.19 branches have same results.
One diff from the 5008 POC is that I don't add the ParameterNamesModule.