Skip to content

Conversation

@pjfanning
Copy link
Member

@pjfanning pjfanning commented Mar 6, 2025

I see the disabled test fail in 2.19, 2.18 and 2.17 branches and the enabled test pass on all 3 branches but this could be an issue on my side.

#5011 shows the 'failing' test fails in 2.17 branch and the passing test passes - so 2.17 and 2.19 branches have same results.

One diff from the 5008 POC is that I don't add the ParameterNamesModule.

@cowtowncoder
Copy link
Member

cowtowncoder commented Mar 6, 2025

Yes, it's all about Parameter Names module -- databind has test AnnotationIntrospector to imitate that (cannot add dependency).

But this is not an actual valid test case in that behavior is expected: 1-param auto-detection case considers this to imply "Properties" style due to existence of getValue() and named parameter for "value".

So no need for test case. Unless I guess we want to add test to show expected behavior (but we might already have one -- can't say off-hand).

@pjfanning pjfanning closed this Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants