yang: add vrf ref to interface model by chiragshah6 · Pull Request #5751 · FRRouting/frr

chiragshah6 · 2020-02-03T21:41:43Z

module: frr-interface
  +--rw lib
     +--rw interface* [name vrf]
        +--rw name           string
        +--rw vrf            frr-vrf:vrf-ref
        +--rw description?   string

Signed-off-by: Chirag Shah chirag@cumulusnetworks.com

NetDEF-CI · 2020-02-03T22:06:26Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10592/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10592/artifact/CI009BUILD/ErrorLog/log_make.txt)

 9595 |    CPP_NOTICE(
ospfd/ospf_neighbor.c: In function 'ospf_nbr_lookup':
ospfd/ospf_neighbor.c:410:45: error: taking address of packed member of 'struct ip' may result in an unaligned pointer value [-Werror=address-of-packed-member]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:7471: ospfd/ospf_neighbor.o] Error 1
In file included from ./lib/yang_wrappers.h:23,
eigrpd/eigrp_packet.c: In function 'eigrp_read':
eigrpd/eigrp_packet.c:552:25: error: taking address of packed member of 'struct ip' may result in an unaligned pointer value [-Werror=address-of-packed-member]
./lib/prefix.h:344:46: note: in definition of macro 'IPV4_ADDR_SAME'

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10592/artifact/CI009BUILD/config.status/config.status

Successful on other platforms

NetBSD 6 amd64 build
CentOS 7 amd64 build
Debian 10 amd64 build
Debian 8 amd64 build
Ubuntu 14.04 amd64 build
FreeBSD 12 amd64 build
OpenBSD 6 amd64 build
NetBSD 8 amd64 build
Ubuntu 16.04 amd64 build
Ubuntu 18.04 amd64 build
Debian 9 amd64 build
Ubuntu 12.04 amd64 build
Ubuntu 18.04 ppc64le build
Ubuntu 16.04 i386 build
Fedora 29 amd64 build

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10592/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: pkg-js-tools-test-is-missing
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200203-00-gb4798985a-0 (missing) -> 7.3-dev-20200203-00-gb4798985a-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200203-00-gb4798985a-0 (missing) -> 7.3-dev-20200203-00-gb4798985a-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200203-00-gb4798985a-0 (missing) -> 7.3-dev-20200203-00-gb4798985a-0~deb10u1
W: frr: spelling-error-in-readme-debian explecitly explicitly
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200203-00-gb4798985a-0 (missing) -> 7.3-dev-20200203-00-gb4798985a-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200203-00-gb4798985a-0 (missing) -> 7.3-dev-20200203-00-gb4798985a-0~deb10u1

rwestphal

LGTM

rwestphal · 2020-02-04T02:08:24Z

CI:rerun

NetDEF-CI · 2020-02-04T02:31:47Z

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10593/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

FreeBSD 11 amd64 build: Failed (click for details)

Make failed for FreeBSD 11 amd64 build:
(see full Make log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10593/artifact/CI009BUILD/ErrorLog/log_make.txt)

 9595 |    CPP_NOTICE(
ospfd/ospf_neighbor.c: In function 'ospf_nbr_lookup':
ospfd/ospf_neighbor.c:410:45: error: taking address of packed member of 'struct ip' may result in an unaligned pointer value [-Werror=address-of-packed-member]
cc1: all warnings being treated as errors
gmake[1]: *** [Makefile:7471: ospfd/ospf_neighbor.o] Error 1
In file included from ./lib/yang_wrappers.h:23,
eigrpd/eigrp_packet.c: In function 'eigrp_read':
eigrpd/eigrp_packet.c:552:25: error: taking address of packed member of 'struct ip' may result in an unaligned pointer value [-Werror=address-of-packed-member]
./lib/prefix.h:344:46: note: in definition of macro 'IPV4_ADDR_SAME'

FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10593/artifact/CI009BUILD/config.status/config.status

Successful on other platforms

CentOS 7 amd64 build
Ubuntu 14.04 amd64 build
Debian 10 amd64 build
Debian 8 amd64 build
FreeBSD 12 amd64 build
OpenBSD 6 amd64 build
NetBSD 8 amd64 build
Debian 9 amd64 build
Ubuntu 16.04 amd64 build
Ubuntu 18.04 amd64 build
NetBSD 6 amd64 build
Ubuntu 12.04 amd64 build
Ubuntu 18.04 ppc64le build
Fedora 29 amd64 build
Ubuntu 16.04 i386 build

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10593/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: pkg-js-tools-test-is-missing
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200203-00-gb4798985a-0 (missing) -> 7.3-dev-20200203-00-gb4798985a-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200203-00-gb4798985a-0 (missing) -> 7.3-dev-20200203-00-gb4798985a-0~deb10u1
W: frr: spelling-error-in-readme-debian explecitly explicitly
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200203-00-gb4798985a-0 (missing) -> 7.3-dev-20200203-00-gb4798985a-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200203-00-gb4798985a-0 (missing) -> 7.3-dev-20200203-00-gb4798985a-0~deb10u1
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.3-dev-20200203-00-gb4798985a-0 (missing) -> 7.3-dev-20200203-00-gb4798985a-0~deb10u1

Spantik · 2020-02-04T03:01:53Z

CI:rerun

I think I need to rebase the branch. It is 400+ commit behind master and many yang PR are failing. I will do that today.

qlyoung · 2020-02-04T16:22:51Z

@chiragshah6 we're going to rebase nb_conversions today; after that, please rebase this branch against it so we can pass CI

module: frr-interface +--rw lib +--rw interface* [name vrf] +--rw name string +--rw vrf frr-vrf:vrf-ref +--rw description? string Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>

NetDEF-CI · 2020-02-04T22:39:21Z

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10613/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Debian 10 amd64 build: Successful with additional warnings

Debian Package lintian failed for Debian 10 amd64 build:
(see full package build log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-10613/artifact/DEB10BUILD/ErrorLog/log_lintian.txt)

W: frr source: pkg-js-tools-test-is-missing
W: frr source: pkg-js-tools-test-is-missing
W: frr-rpki-rtrlib: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200204-10-g87ee53fc9-0 (missing) -> 7.4-dev-20200204-10-g87ee53fc9-0~deb10u1
W: frr-doc: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200204-10-g87ee53fc9-0 (missing) -> 7.4-dev-20200204-10-g87ee53fc9-0~deb10u1
W: frr: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200204-10-g87ee53fc9-0 (missing) -> 7.4-dev-20200204-10-g87ee53fc9-0~deb10u1
W: frr-pythontools: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200204-10-g87ee53fc9-0 (missing) -> 7.4-dev-20200204-10-g87ee53fc9-0~deb10u1
W: frr-snmp: changelog-file-missing-explicit-entry 6.0-2 -> 7.4-dev-20200204-10-g87ee53fc9-0 (missing) -> 7.4-dev-20200204-10-g87ee53fc9-0~deb10u1

polychaeta added the yang label Feb 3, 2020

rwestphal approved these changes Feb 4, 2020

View reviewed changes

qlyoung self-requested a review February 4, 2020 16:21

qlyoung approved these changes Feb 4, 2020

View reviewed changes

yang: add vrf ref to interface model

87ee53f

module: frr-interface +--rw lib +--rw interface* [name vrf] +--rw name string +--rw vrf frr-vrf:vrf-ref +--rw description? string Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>

chiragshah6 force-pushed the yang_nb1 branch from b479898 to 87ee53f Compare February 4, 2020 19:20

rwestphal merged commit 5dd164b into FRRouting:nb_conversions Feb 5, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

yang: add vrf ref to interface model#5751

yang: add vrf ref to interface model#5751
rwestphal merged 1 commit into
FRRouting:nb_conversionsfrom
chiragshah6:yang_nb1

chiragshah6 commented Feb 3, 2020

Uh oh!

NetDEF-CI commented Feb 3, 2020

Uh oh!

rwestphal left a comment

Uh oh!

rwestphal commented Feb 4, 2020

Uh oh!

NetDEF-CI commented Feb 4, 2020

Uh oh!

Spantik commented Feb 4, 2020

Uh oh!

qlyoung commented Feb 4, 2020

Uh oh!

NetDEF-CI commented Feb 4, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

chiragshah6 commented Feb 3, 2020

Uh oh!

NetDEF-CI commented Feb 3, 2020

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

Uh oh!

rwestphal left a comment

Choose a reason for hiding this comment

Uh oh!

rwestphal commented Feb 4, 2020

Uh oh!

NetDEF-CI commented Feb 4, 2020

Continuous Integration Result: FAILED

Get source / Pull Request: Successful

Building Stage: Failed

Warnings Generated during build:

Uh oh!

Spantik commented Feb 4, 2020

Uh oh!

qlyoung commented Feb 4, 2020

Uh oh!

NetDEF-CI commented Feb 4, 2020

Continuous Integration Result: SUCCESSFUL

Warnings Generated during build:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants