-
Notifications
You must be signed in to change notification settings - Fork 54
Support period in lora name #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you this looks solid. Just going to try it real quick and then merge it into main. |
Actually ended up having an error during the actual lora loading. I wonder if peft can't handle the "." and we need to at least rename it internally.
|
@colinurbs I'll test some more. I had a dirty branch with a ton of local changes and I ended up partial staging this patch. |
https://github.com/pytorch/pytorch/pull/6639/files#diff-4be56271f7bfe650e3521c81fd363da58f109cd23ee80d243156d2d6ccda6263R133-R134 ``` Loading pixar_7.epochs was unsucessful with the following error: 'module name can\'t contain ".", got: pixar_7.epochs' Traceback (most recent call last): File "/home/colin/FramePack/studio.py", line 571, in worker ```
@colinurbs Seems to work with this last change. I'm not sure if this is a great way to handle it with the type of audience that is currently using the codebase. The suggested method is to just remove every |
Will need further testing. I'll set up a clean install and run through a few scenarios in the next day or so, unless you have time to go through the tests.
|
@colinurbs manual tests passed. The only time that the tests failed was when a cancellation was sent while |
Yeah please open a ticket for that. Thanks for your testing! |
Fixes #75