-
Notifications
You must be signed in to change notification settings - Fork 0
ProfileScreen rework: visual refresh, edit UX overhaul, settings expansion #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
f43e99b
f04f9a5
c0e3e0a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,21 @@ | ||||||||||||||||||||||
| name: Lint and Build | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| on: | ||||||||||||||||||||||
| push: | ||||||||||||||||||||||
| branches: [ main ] | ||||||||||||||||||||||
| pull_request: | ||||||||||||||||||||||
| branches: [ main ] | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| jobs: | ||||||||||||||||||||||
| build: | ||||||||||||||||||||||
| runs-on: ubuntu-latest | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| steps: | ||||||||||||||||||||||
| - uses: actions/checkout@v2 | ||||||||||||||||||||||
| - name: Use Node.js | ||||||||||||||||||||||
| uses: actions/setup-node@v2 | ||||||||||||||||||||||
| with: | ||||||||||||||||||||||
| node-version: '22.x' | ||||||||||||||||||||||
|
Comment on lines
+14
to
+18
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick | 🔵 Trivial 🧩 Analysis chain🏁 Script executed: cat -n .github/workflows/main.ymlRepository: FLAiRistaken/firsthand Length of output: 579 🌐 Web query:
💡 Result: actions/checkout@v2 remains compatible with modern GitHub-hosted runners in 2025-2026 and is not deprecated. The v2 tag points to v2.0.0 (released ~2019), which uses an older Node.js runtime (likely node16 or earlier). Modern GitHub-hosted runners (ubuntu-latest pointing to ubuntu-24.04 as of late 2024, with runner versions v2.327+ in 2025-2026 supporting Node 20/24) fully support legacy Node versions including those used by v2. No deprecation notices exist for actions/checkout@v2 in official GitHub sources; deprecations target specific other actions like actions/cache v1-v2 or OS images like ubuntu-20.04 (retired April 2025). Self-hosted runners require version v2.329.0+ (enforced for new configs from March 2026) but support all checkout versions including v2. Users should upgrade to v6 (latest as of Jan 2026, Node24 runtime, requires runner v2.327.1+) for new features like improved credential security and performance, but v2 continues to function without issues on current infrastructure. Citations:
🌐 Web query:
💡 Result: The actions/setup-node action requires GitHub Actions runners that support the Node.js runtime version specified in its action.yml 'runs.using' field. v2 (https://github.com/actions/setup-node/tree/releases/v2): Likely uses 'node16' (common for older versions), compatible with runners from ~v2.280+ that support node16. v4 (latest release v4.4.0): Uses 'node20' runtime. Compatible with GitHub-hosted runners (all current ones) and self-hosted runners v2.317.0+ (when Node 20 became default). Earlier runners may require ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true for node16 fallback if pinned to older checkout/setup actions. Newer versions (v5+, v6): Use 'node24' runtime (action.yml main branch), requiring runner v2.327.1+ explicitly stated in README: "Make sure your runner is on version v2.327.1 or later to ensure compatibility with this release." For self-hosted runners without pre-installed Node.js, setup-node@v4+ may fail as it runs using the runner's Node.js (issue Citations:
Upgrade GitHub Actions to more recent versions for improved security and performance.
Suggested change- - uses: actions/checkout@v2
+ - uses: actions/checkout@v4
- name: Use Node.js
- uses: actions/setup-node@v2
+ uses: actions/setup-node@v4📝 Committable suggestion
Suggested change
🧰 Tools🪛 actionlint (1.7.12)[error] 14-14: the runner of "actions/checkout@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue (action) [error] 16-16: the runner of "actions/setup-node@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue (action) 🤖 Prompt for AI Agents |
||||||||||||||||||||||
| - run: npm install | ||||||||||||||||||||||
| - run: npm install -g typescript | ||||||||||||||||||||||
| - run: tsc --noEmit | ||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| import React from 'react'; | ||
| import Svg, { Path } from 'react-native-svg'; | ||
| import { Colors } from '../../constants/theme'; | ||
|
|
||
| interface Props { | ||
| size?: number; | ||
| color?: string; | ||
| } | ||
|
|
||
| export const GearIcon: React.FC<Props> = ({ size = 12, color = Colors.primary }) => { | ||
| return ( | ||
| <Svg | ||
| width={size} | ||
| height={size} | ||
| viewBox="0 0 24 24" | ||
| fill="none" | ||
| stroke={color} | ||
| strokeWidth={1.5} | ||
| strokeLinecap="round" | ||
| strokeLinejoin="round" | ||
| > | ||
| <Path d="M12 15C13.6569 15 15 13.6569 15 12C15 10.3431 13.6569 9 12 9C10.3431 9 9 10.3431 9 12C9 13.6569 10.3431 15 12 15Z" /> | ||
| <Path d="M19.4 15a1.65 1.65 0 0 0 .33 1.82l.06.06a2 2 0 0 1-2.83 2.83l-.06-.06a1.65 1.65 0 0 0-1.82-.33 1.65 1.65 0 0 0-1 1.51V21a2 2 0 0 1-4 0v-.09A1.65 1.65 0 0 0 9 19.4a1.65 1.65 0 0 0-1.82.33l-.06.06a2 2 0 0 1-2.83-2.83l.06-.06A1.65 1.65 0 0 0 4.68 15a1.65 1.65 0 0 0-1.51-1H3a2 2 0 0 1 0-4h.09A1.65 1.65 0 0 0 4.6 9a1.65 1.65 0 0 0-.33-1.82l-.06-.06a2 2 0 0 1 2.83-2.83l.06.06A1.65 1.65 0 0 0 9 4.68a1.65 1.65 0 0 0 1-1.51V3a2 2 0 0 1 4 0v.09a1.65 1.65 0 0 0 1 1.51 1.65 1.65 0 0 0 1.82-.33l.06-.06a2 2 0 0 1 2.83 2.83l-.06.06A1.65 1.65 0 0 0 19.4 9a1.65 1.65 0 0 0 1.51 1H21a2 2 0 0 1 0 4h-.09a1.65 1.65 0 0 0-1.51 1z" /> | ||
| </Svg> | ||
| ); | ||
| }; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| import React from 'react'; | ||
| import Svg, { Path } from 'react-native-svg'; | ||
| import { Colors } from '../../constants/theme'; | ||
|
|
||
| interface Props { | ||
| size?: number; | ||
| color?: string; | ||
| } | ||
|
|
||
| export const TargetIcon: React.FC<Props> = ({ size = 12, color = Colors.primary }) => { | ||
| return ( | ||
| <Svg | ||
| width={size} | ||
| height={size} | ||
| viewBox="0 0 24 24" | ||
| fill="none" | ||
| stroke={color} | ||
| strokeWidth={1.5} | ||
| strokeLinecap="round" | ||
| strokeLinejoin="round" | ||
| > | ||
| <Path d="M12 22C17.5228 22 22 17.5228 22 12C22 6.47715 17.5228 2 12 2C6.47715 2 2 6.47715 2 12C2 17.5228 6.47715 22 12 22Z" /> | ||
| <Path d="M12 17C14.7614 17 17 14.7614 17 12C17 9.23858 14.7614 7 12 7C9.23858 7 7 9.23858 7 12C7 14.7614 9.23858 17 12 17Z" /> | ||
| </Svg> | ||
| ); | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run this workflow for
developPRs too.This job currently only runs for PRs into
main, so it will not protect this PR or any other merge intodevelop. The new TypeScript gate is effectively bypassed on the branch you are targeting here.Suggested change
🧰 Tools
🪛 YAMLlint (1.38.0)
[warning] 3-3: truthy value should be one of [false, true]
(truthy)
[error] 5-5: too many spaces inside brackets
(brackets)
[error] 5-5: too many spaces inside brackets
(brackets)
[error] 7-7: too many spaces inside brackets
(brackets)
[error] 7-7: too many spaces inside brackets
(brackets)
🤖 Prompt for AI Agents