Skip to content

Improve demo dimension usage - #4039

Merged
schnellerhase merged 4 commits into
mainfrom
schnellerhase/dims
Jan 13, 2026
Merged

Improve demo dimension usage#4039
schnellerhase merged 4 commits into
mainfrom
schnellerhase/dims

Conversation

@schnellerhase

@schnellerhase schnellerhase commented Jan 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Removes hard coded dimensionality and follows consistent usage of notation

gdim = msh.geometry.dim
tdim = msh.topology.dim
fdim = tdim - 1

@schnellerhase schnellerhase added housekeeping Tidying and style improvements demo New demo or demo enhancements/improvements labels Jan 13, 2026
@schnellerhase schnellerhase changed the title Improve demos entity dimensions usage Improve demo dimension usage Jan 13, 2026
@schnellerhase
schnellerhase marked this pull request as ready for review January 13, 2026 14:33
jorgensd
jorgensd approved these changes Jan 13, 2026
View reviewed changes

@jorgensd jorgensd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schnellerhase
schnellerhase added this pull request to the merge queue Jan 13, 2026
Merged via the queue into main with commit f094487 Jan 13, 2026
19 checks passed
@schnellerhase
schnellerhase deleted the schnellerhase/dims branch January 13, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorgensd jorgensd jorgensd approved these changes
@michalhabera michalhabera Awaiting requested review from michalhabera

Assignees

No one assigned

Labels

demo New demo or demo enhancements/improvements housekeeping Tidying and style improvements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@schnellerhase @jorgensd