Skip to content

fix build with adios2 v2.11.0 - #4004

Merged
jhale merged 5 commits into
FEniCS:mainfrom
qbisi:adios2
Nov 27, 2025
Merged

fix build with adios2 v2.11.0#4004
jhale merged 5 commits into
FEniCS:mainfrom
qbisi:adios2

Conversation

@qbisi

@qbisi qbisi commented Nov 25, 2025

Copy link
Copy Markdown
Contributor

The target cxx11_mpi has been renamed to cxx_mpi since adios2 v2.11.0.

@qbisi

qbisi commented Nov 25, 2025

Copy link
Copy Markdown
Contributor Author

either commits will fix build with adios2 v2.11.0

note adios2 v2.11.0 make alias interface cxx11_mpi to cxx_mpi when we explicity require the MPI component in finding adios2.

see adios2-config-common.cmake

if(ADIOS2_HAVE_MPI AND "MPI" IN_LIST ${CMAKE_FIND_PACKAGE_NAME}_FIND_COMPONENTS)
  find_dependency(MPI)
  set(${CMAKE_FIND_PACKAGE_NAME}_MPI_FOUND ${MPI_FOUND})
else()
  set(${CMAKE_FIND_PACKAGE_NAME}_MPI_FOUND FALSE)
endif()

...

  if(${CMAKE_FIND_PACKAGE_NAME}_MPI_FOUND)
     add_library(adios2::cxx11_mpi INTERFACE IMPORTED)
     target_link_libraries(adios2::cxx11_mpi INTERFACE adios2::cxx_mpi)
     if(CMAKE_VERSION VERSION_GREATER_EQUAL 3.17)
       set_target_properties(adios2::cxx11_mpi PROPERTIES
         DEPRECATION "adios2::cxx11_mpi target has been deprecated, please use adios2::cxx_mpi")
     endif()
  endif()

@schnellerhase

Copy link
Copy Markdown
Contributor

New ADIOS version also breaks current spack develop builds.

@schnellerhase

Copy link
Copy Markdown
Contributor

Can you bump to v2.11.0 here as well?

The target cxx11_mpi has been renamed to cxx_mpi since adios2 v2.11.
@schnellerhase schnellerhase added build Build system and compiler issues dependencies Pull requests that update a dependency file labels Nov 26, 2025
@schnellerhase

Copy link
Copy Markdown
Contributor

Spack CI ran with ADIOS2 v2.10.2 here and against v2.11.0 here

@schnellerhase
schnellerhase requested a review from jhale November 26, 2025 15:44
@jhale
jhale added this pull request to the merge queue Nov 27, 2025
@jhale
jhale removed this pull request from the merge queue due to a manual request Nov 27, 2025
@jhale
jhale enabled auto-merge November 27, 2025 08:28
@jhale

jhale commented Nov 27, 2025

Copy link
Copy Markdown
Member

This should probably be backported, otherwise we'll need to deal with huge numbers of build errors for DOLFINx v0.10.

@jhale
jhale added this pull request to the merge queue Nov 27, 2025
Merged via the queue into FEniCS:main with commit 13d9b06 Nov 27, 2025
16 of 17 checks passed
@qbisi

qbisi commented Nov 27, 2025

Copy link
Copy Markdown
Contributor Author

Hi, do you have plan to publish a post release with this patch backported?

jhale added a commit that referenced this pull request Nov 27, 2025
* fix build with adios2 v2.11

The target cxx11_mpi has been renamed to cxx_mpi since adios2 v2.11.

* find adios2 with component MPI

* BUMP adios2 to 2.11.0

* Small tweaks

---------

Co-authored-by: Paul T. Kühner <56360279+schnellerhase@users.noreply.github.com>
Co-authored-by: Jack S. Hale <mail@jackhale.co.uk>
@jhale

jhale commented Nov 27, 2025

Copy link
Copy Markdown
Member

Yes, it's done - checkout tag v0.10.0.post4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Build system and compiler issues dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants