NonlinearProblem docstring improvements - #3765
Merged
Merged
Conversation
jorgensd
reviewed
Jun 24, 2025
…finx into jhale/post-petsc-wrapper-tidy
ordinary-slim
pushed a commit
to ordinary-slim/dolfinx
that referenced
this pull request
Jul 6, 2025
* Fix up doc strings. * Fix. * Further consistency and options safety fixes. * Further tweaks. * Ruff format * More consistency fixes. * Fix. * More fixes. * More use of properties internally. * Update petsc.py * Fix. * Guard entire options setting process - nullop if not passed. * Fix. * More tweaks. * Ruff format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
x(Vector solution used by KSP/SNES) andu(Function solution returned by solve).petsc_optionsare now only applied to KSP or the SNES, not the linear algebra objects - this is made explicit in the docstring. The previous LinearSolver also applied the options toAandb, but it wasn't clear why these were not applied toxand the newPobject. It's also not clear whether one would want the same options applied to multiple different linear algebra objects.