Add AdjacencyList python wrapper - #3509
Merged
Merged
Conversation
schnellerhase
force-pushed
the
adjlist_wrapper
branch
10 times, most recently
from
November 16, 2024 11:44
bf1b8a1 to
3466313
Compare
schnellerhase
force-pushed
the
adjlist_wrapper
branch
from
November 16, 2024 12:03
3466313 to
468f8a2
Compare
schnellerhase
marked this pull request as ready for review
November 16, 2024 12:32
jorgensd
reviewed
Nov 17, 2024
jorgensd
reviewed
Nov 17, 2024
jorgensd
reviewed
Nov 17, 2024
| is_32bit = data.dtype == np.int32 | ||
| cpp_t = _cpp.graph.AdjacencyList_int32 if is_32bit else _cpp.graph.AdjacencyList_int64 | ||
| cpp_object = cpp_t(data, offsets) if offsets is not None else cpp_t(data) | ||
| return AdjacencyList(cpp_object) |
Member
There was a problem hiding this comment.
So we need a guard for invalid input style (ie np.floating), or do we think the general nanobind error is sufficient? Usually the nanobind type arrays aren’t very expressive when it comes to dtype.
Contributor
Author
There was a problem hiding this comment.
Defending against such calls would require quite a bit of additional logic. It doesn't end there if we did that, then we would need for example also checks of the shapes of the arrays.
Given that it can not cause a false positive, i.e. if we call with a float array it will not result in a working code path that produces bad results, and type hints being present, that should flag this in a modern IDE or with mypy, I think we should stick to the simplicity of not dealing with it.
jorgensd
reviewed
Nov 17, 2024
jorgensd
reviewed
Nov 17, 2024
jorgensd
reviewed
Nov 17, 2024
Co-authored-by: Jørgen Schartum Dokken <dokken92@gmail.com>
jhale
reviewed
Nov 22, 2024
This was referenced Dec 3, 2024
schnellerhase
added a commit
to schnellerhase/fenics-dolfinx
that referenced
this pull request
Dec 28, 2024
* Add adjacency list python wrapper * Fix type hint * Add docstrings * Apply suggestions from code review Co-authored-by: Jørgen Schartum Dokken <dokken92@gmail.com> * Ruff * Add TODO: * Fix default is int64 behavior * Apply suggested docstring --------- Co-authored-by: Jørgen Schartum Dokken <dokken92@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a python wrapper for the multi-type exported
AdjacencyList.Addresses (partially) #3483