Demo updates for LU solver bugs - #3499
Merged
Merged
Conversation
garth-wells
enabled auto-merge
November 6, 2024 08:27
schnellerhase
pushed a commit
to schnellerhase/fenics-dolfinx
that referenced
this pull request
Dec 28, 2024
* Docker update * Type fixes in pyvista demo * Change solver type * More solver switches * Demo update * Run all tests * Test update * Try mumps option * Demo update * Demo update * Update * Update * mypy fix * Update * Try superlu * Lint * Demo update * Demo update * Updates * Update * Update * Update * Demo update * Update * Update * Lint * mypy fixex * Tidy up * Lint * Formatting fixes * Logic fix * Formatting fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MUMPS and SuperLU_dist can be shaky for less common types, i.e. other than
float64andint32. This change picks a solver that works for each of the combinations tested on the CI.