Remove pugixml source from repository - #2208
Merged
Merged
Conversation
garth-wells
changed the title
jorgensd
approved these changes
May 26, 2022
garth-wells
marked this pull request as ready for review
May 27, 2022 08:10
chrisrichardson
approved these changes
May 27, 2022
chrisrichardson
left a comment
chrisrichardson
left a comment
Contributor
There was a problem hiding this comment.
I'm fairly ambivalent about this. Adding more installation dependencies vs. a single file which needs updating from time-to-time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
pugixmlsource from the repository.pugixmlis now widely available in package managers, e.g. homebrew, Debian/Ubuntu, Spack.pugixmlis installed in the CI yaml files at the moment. This will move to the Docker images if this PR gets merged.Fixes #2005.