Skip to content

Fix array2d for USM allocators - #1589

Merged
garth-wells merged 1 commit into
mainfrom
igor/more-templating
Jun 28, 2021
Merged

Fix array2d for USM allocators#1589
garth-wells merged 1 commit into
mainfrom
igor/more-templating

Conversation

@IgorBaratta

Copy link
Copy Markdown
Member
_storage = std::vector<T, Allocator>(shape[0] * shape[1], value, alloc);

Calls a deleted copy constructor with USM allocator.

@garth-wells

Copy link
Copy Markdown
Member

I'm wondering if we should remove array2d and just pass a std::vector/std::span and the row offset.

@garth-wells
garth-wells merged commit dfa63de into main Jun 28, 2021
@garth-wells
garth-wells deleted the igor/more-templating branch June 28, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants