Link authentication and user profile to homepage#394
Conversation
taterhead247
requested review from
dnishiyama,
evanpetzoldt and
pstaylor-patrick
as code owners
|
Warning Review limit reached
More reviews will be available in 23 minutes and 4 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThree small UI/content updates: auth page sign-in copy now confirms sign-in and links to apps.f3nation.com; homepage Admin app card shows custom "Open (region admins only)" label; profile header becomes a two-column grid with an "Explore F3 Nation" link. ChangesNavigation and Messaging UI Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR improves ecosystem discoverability across the F3 Nation apps by adding prominent links to the central apps directory and clarifying an admin-only destination on the homepage directory.
Changes:
- Adds an “Explore F3 Nation” card to the F3 Me profile header linking to
https://apps.f3nation.com. - Updates the Auth homepage signed-in confirmation text and includes a link to the ecosystem directory.
- Adds a clearer link label for the Admin entry on the ecosystem homepage (“Open (region admins only)”).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/me/src/components/profile-form.tsx | Adds ecosystem discovery card + link in the profile header area. |
| apps/homepage/src/app/page.tsx | Adds an explicit “region admins only” label to the Admin app card link. |
| apps/auth/src/app/page.tsx | Updates signed-in confirmation messaging and adds a link to the ecosystem directory. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apps/homepage/src/app/page.tsx (1)
35-40:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winAlign the access label with the actual admin auth contract.
"Open (region admins only)"is narrower than what the admin app actually enforces:apps/admin/src/lib/auth/server.ts:88-105grants access to users with eitherroleName === "admin"orroleName === "editor", andapps/admin/src/app/layout.tsx:31-42applies that check on protected admin routes. This copy will incorrectly discourage authorized editors from opening the portal. Please broaden the label to match the allowed roles (for example, “Open (authorized leaders only)” or similar).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/homepage/src/app/page.tsx` around lines 35 - 40, The linkLabel "Open (region admins only)" is too narrow; update it in apps/homepage/src/app/page.tsx to reflect the actual admin auth contract (apps/admin/src/lib/auth/server.ts checks roleName === "admin" or roleName === "editor" and apps/admin/src/app/layout.tsx enforces that on protected routes). Change linkLabel to a broader phrase such as "Open (authorized leaders only)" or similar so editors are not discouraged from accessing the portal.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/me/src/components/profile-form.tsx`:
- Around line 71-76: The anchor that renders the external portal link in
profile-form (the <a> element with href "https://apps.f3nation.com") should open
in a new tab and include safe rel attributes to avoid losing unsaved form state;
update that anchor to add target="_blank" and rel="noopener noreferrer" so
clicks open a new tab securely without navigating away from the current form.
---
Outside diff comments:
In `@apps/homepage/src/app/page.tsx`:
- Around line 35-40: The linkLabel "Open (region admins only)" is too narrow;
update it in apps/homepage/src/app/page.tsx to reflect the actual admin auth
contract (apps/admin/src/lib/auth/server.ts checks roleName === "admin" or
roleName === "editor" and apps/admin/src/app/layout.tsx enforces that on
protected routes). Change linkLabel to a broader phrase such as "Open
(authorized leaders only)" or similar so editors are not discouraged from
accessing the portal.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 17e856db-1c09-4384-922d-2e1da34d07bb
📒 Files selected for processing (3)
apps/auth/src/app/page.tsxapps/homepage/src/app/page.tsxapps/me/src/components/profile-form.tsx
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/me/src/components/profile-form.tsx`:
- Line 75: In the ProfileForm component update the button/input class string
that currently contains "focus-visible:outline-none" to use
"focus-visible:outline-hidden" instead; locate the className on the interactive
element in profile-form.tsx (the element with the long className including
"focus-visible:ring-2 focus-visible:ring-ring") and replace that token so the
native outline can still appear in forced-colors/high-contrast while keeping
your custom focus-visible ring styles.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: da37e3cd-961b-4797-b387-327a3d29999d
📒 Files selected for processing (1)
apps/me/src/components/profile-form.tsx
|
@BigGillyStyle , do you mind reviewing this when you get a chance. Apparently I put in a rule that I can't approve my own PRs 😄 . No rush |
|
I pulled down the branch locally and compared the Auth, Me, and Homepage screens with what is stated in the PR description. All seems to align. Claude Code did find one minor technical consistency issue. |
github-project-automation
Bot
moved this from Initiated
to Merged
in F3 Nation Tech (Pull Requests)
This pull request enhances the user experience by improving messaging and discoverability of the broader F3 Nation ecosystem across multiple pages. It updates sign-in confirmation messaging, adds clearer labels for admin-only links, and introduces a new section in the profile form to help users explore related F3 Nation applications.
Ecosystem Discovery Enhancements:
profile-form.tsx) that introduces users to the F3 Nation ecosystem and provides a prominent link toapps.f3nation.com. [1] [2]UI and Label Improvements:
Summary by CodeRabbit
New Features
Updates
UX