-
Notifications
You must be signed in to change notification settings - Fork 91
fix Firefox arrow navigation bug #683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jmusial
wants to merge
5
commits into
Expensify:main
Choose a base branch
from
jmusial:emoji-arrow-navigation-firefox-bug
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix Firefox arrow navigation bug #683
jmusial
wants to merge
5
commits into
Expensify:main
from
jmusial:emoji-arrow-navigation-firefox-bug
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All contributors have signed the CLA ✍️ ✅ |
recheck |
tomekzaw
reviewed
May 25, 2025
jmusial
commented
May 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While testing noticed that the issue is also present for left arrow when navigating backwards and /or with multiple emojis. Added code and test cases to cover that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes navigation bug on Firefox, where navigation using arrows over emojis requires 2 key presses.
Screen.Recording.2025-05-21.at.09.55.11.mov
Details
In Firefox, the arrow key navigation treats surrogate pairs (like emojis) as two separate code units, while Chromium browsers treat them as a single character. This discrepancy causes the “double-arrow press” behaviour.
Related Issues
GH_LINK
Manual Tests
Videos
Before
LM_emojis_before.mov
After
LM_emojis_after.mov
Linked PRs