PopupViewer improperly showing back-arrow for sublayers

[mquetel]

When displaying popups from a referenced service with sublayers, the PopupViewer will initially show the popup without a back arrow. If the popup property value is changed to a different popup (same service, different popup, same or different sublayer), the viewer shows a back button. It's my understanding according to this esri community exchange that showing the back button for this scenario is not by design. The back button seems to act like a browser back button, stepping backwards to all the previous popups that have been set.

In my scenario this is undesirable as the navigation happens on the left pane of my popup UI, using an item/item detail metaphor.

The first popup looks like this:

Setting the property to another popup looks like this:

The map service being used, is a referenced service where the publishing document has feature classes stored within group layers:

[dotMorten]

I'm assuming this is WPF? I did a bit of experimentation with it and couldn't reproduce it.
Stepping through the code, this seems to evaluate correctly each time:

arcgis-maps-sdk-dotnet-toolkit/src/Toolkit/Toolkit/UI/Controls/PopupViewer/NavigationSubView.cs

Line 62 in 4b98f12

back.Visibility = _navigationStack.Count > 0 ? Visibility.Visible : Visibility.Collapsed;

Could you share some code how you're using the popupviewer, or even better a small repro?

[dotMorten]

Btw this PR that was made after 200.8 shipped does also improve how navigation is handled, and could potentially fix your issue: #690
(Having said that, I tried to reproduce your issue with code from before that fix went in)

[mquetel]

Yes, this is WPF.

Pseudo code of what I am doing:

• Get the IdentifyLayerResult result from MapView.IdentifyLayersAsync().
• There will be no geoelements or popups in result we need to recurse through result.SubLayerResults because of the organization of the service.
• No popups are defined, so the popups count for a result will be 0. Instead I iterate through result.GeoElements making a PopupDefinition for each using the .FromGeoElement factory method.
• A new Popup is then instantiated by passing the geoelement and popup definition into the constructor.
• All popups are stored in a collection. As the user clicks on a Popup (which is represented by the underlying geoelement's display text, the popup property on the viewer control is set to that popup.

Observations:

• The first time the popup property is set, no backup button is displayed.
• Subsequent setting of the property displays the back button.
• The back button acts like a browser back button going back through each previous popup that was set.
• Nulling the popup property (each time) before setting it to a valid popup prevents the back button from ever showing.

[mquetel]

Btw this PR that was made after 200.8 shipped does also improve how navigation is handled, and could potentially fix your issue: #690 (Having said that, I tried to reproduce your issue with code from before that fix went in)

Interesting. Do updates to the toolkit nuget package happen in concert with the SDK or do you make updates in between?

[dotMorten]

Do updates to the toolkit nuget package happen in concert with the SDK

We make fixes here in the repo as soon as we have them so you can get them as well, but we generally only ship in concert with the SDK. You are more than welcome to just clone this repo and build your own version of the nuget package to get the fixes early.

I'm still curious about an actual reproducer sample, since I wasn't able to reproduce the issue even prior to the mentioned improvement, and my steps are pretty similar to what you describe above.

Subsequent setting of the property displays the back button.

I do believe it fixed an issue with this specifically.

[mquetel]

I'm still curious about an actual reproducer sample, since I wasn't able to reproduce the issue

I'll set a bit of time aside to pull together a reproducer late next week, I'm just headed out of the office for a few work days. I appreciate the dialog on this issue.