fix certificate (zip) download for newer npm installations

[popy2k14]

certificate download failed on my instance until i relaized the api changed.
Maybe a fallback to the old one would be nice.
That is currently not implemented!

[Erreur32]

Thank you @popy2k14 for your contribution !
I will review and test your changes shortly before merging. I’ll keep you updated if anything needs to be adjusted.

[popy2k14]

@Erreur32
Youre welcome :-)

I have made a mistake on the PR:

this:

CERT_FILE=$(ls "$TMP_UNZIP_DIR"/cert8.pem 2>/dev/null) CHAIN_FILE=$(ls "$TMP_UNZIP_DIR"/chain8.pem 2>/dev/null) FULLCHAIN_FILE=$(ls "$TMP_UNZIP_DIR"/fullchain8.pem 2>/dev/null) PRIVKEY_FILE=$(ls "$TMP_UNZIP_DIR"/privkey8.pem 2>/dev/null)

has to be this:

CERT_FILE=$(ls "$TMP_UNZIP_DIR"/cert*.pem 2>/dev/null) CHAIN_FILE=$(ls "$TMP_UNZIP_DIR"/chain*.pem 2>/dev/null) FULLCHAIN_FILE=$(ls "$TMP_UNZIP_DIR"/fullchain*.pem 2>/dev/null) PRIVKEY_FILE=$(ls "$TMP_UNZIP_DIR"/privkey*.pem 2>/dev/null)

I have recognized this later and not update the PR.
Reason for this is that NPM increases the number when the cert is renewed.
Please change this before merging (if needed, i can change my PR, but sadly not much time currently).

Another thing is that i think you should leave the old download code in place, when "null" is in the downloaded conent, then use the new approach. This way we support older and newer npm versions.

Or check some npm api version? (if somthing exists).

Just let me know if you need help.