-
Notifications
You must be signed in to change notification settings - Fork 25
Fix typedef and undef ctors for ConcreteRArray and ConcreteRNumber #1571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't bother deprecating and just deleting the bad one here.
Ok, it's gone. :-) |
1 similar comment
Ok, it's gone. :-) |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1571 +/- ##
===========================================
+ Coverage 21.66% 43.44% +21.77%
===========================================
Files 46 124 +78
Lines 8048 22021 +13973
===========================================
+ Hits 1744 9566 +7822
- Misses 6304 12455 +6151 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
974bda9
to
36882a5
Compare
Are the test failures related to this PR? |
No (and one is simply the coverage step failing to start at all) |
Thanks. I'm good with this from my side then. |
I don't know what I was thinking in #1558, but Julia convention is of course
ArrayType{T}(undef, dims)
andArrayType{T}(undef, dims...)
, but notArrayType(undef, T, dims)
.Also, the typedef for
ConcreteRArray
was missingT
andN
parameters and the typedefs forConcreteRNumber
was missingT
,This PR fixes that (with deprecation for
ConcreteRArray(undef, T, dims; kwargs...)
) and adds tests.