Skip to content

More precompile memory fixups #1525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 4, 2025
Merged

More precompile memory fixups #1525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5e23fa3
More precompile memory fixups
wsmoses Aug 3, 2025
ea934b2
fix
wsmoses Aug 3, 2025
54a6210
fix
wsmoses Aug 3, 2025
1b15577
fix
wsmoses Aug 3, 2025
fcafc72
cleanup
wsmoses Aug 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ext/ReactantCUDAExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1489,7 +1489,16 @@ end
end
y = Reactant.ConcreteRArray([2.0]; client)
Reactant.Compiler.compile_mlir(square!, (y,); optimize=false)
finalize(y)

if y isa Reactant.ConcreteIFRTArray
Reactant.XLA.free_buffer(y.data.buffer)
y.data.buffer.buffer = C_NULL
else
for dat in y.data
Reactant.XLA.free_buffer(dat.buffer)
dat.buffer.buffer = C_NULL
end
end
end
end

Expand Down
20 changes: 18 additions & 2 deletions src/Precompile.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,27 @@ if Reactant_jll.is_available()
@static if precompilation_supported()
x = ConcreteRNumber(2.0; client)
Reactant.compile(sin, (x,); client, optimize=:all)
finalize(x)
if x isa ConcreteIFRTNumber
XLA.free_buffer(x.data.buffer)
x.data.buffer.buffer = C_NULL
else
for dat in x.data
XLA.free_buffer(dat.buffer)
dat.buffer.buffer = C_NULL
end
end

y = ConcreteRArray([2.0]; client)
Reactant.compile(Base.sum, (y,); client, optimize=:all)
finalize(y)
if y isa ConcreteIFRTArray
XLA.free_buffer(y.data.buffer)
y.data.buffer.buffer = C_NULL
else
for dat in y.data
XLA.free_buffer(dat.buffer)
dat.buffer.buffer = C_NULL
end
end
end
end

Expand Down
Loading